switch to jupyter-build, bump NodeJS from 18 to 22#287
Merged
Conversation
jameslamb
commented
Jun 22, 2026
| version: 0.5.7 | ||
| resolution: "@discoveryjs/json-ext@npm:0.5.7" | ||
| checksum: 2176d301cc258ea5c2324402997cf8134ebb212469c0d397591636cea8d3c02f2b3cf9fd58dcb748c7a0dade77ebdc1b10284fa63e608c033a1db52fddc69918 | ||
| "@emnapi/core@npm:1.10.0": |
Member
Author
There was a problem hiding this comment.
All of the changes in this file were made automatically by the hooks in pre-commit, based on the changes I made manually in package.json.
ncclementi
approved these changes
Jun 23, 2026
ncclementi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating this @jameslamb
msarahan
approved these changes
Jun 23, 2026
Member
Author
|
/merge |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286
This project's been using
jupyter labextension buildat build time, but that's been deprecated andjupyter-builder(which pulls the build-time parts out ofjupyterlab) is now recommended. See https://jupyterlab.readthedocs.io/en/4.6.x/extension/extension_migration.html#migrating-to-jupyter-builderThis PR's motivated by an unrelated SSL issue in downloading some packages... switching to
jupyter-builderalso removes that download and unblocks CI. But switching from a deprecated to an officially-supported pattern seems worth doing.This also updates to NodeJS 22 in build environments.
jupyter/builderusesrspackwhich uses some patterns that require at least NodeJS 22, otherwise you hit this in builds:That change has no impact on users, NodeJS is only a build-time dependency here and its version doesn't meaningfully impact the built artifacts.