Add devcontainer fallback for C++ test location - #210
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe CI scripts now locate CTest files through ordered path checks and fail clearly when no location exists. The pytest script now normalizes its working directory to the repository root before execution. ChangesCI path handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to CTest execution can now fall back to the devcontainer test location, and pytest invocation works outside the repository root. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
0ff197b to
66360fe
Compare
|
I've retargeted this at 26.10. I would really like to get it in if possible (allows us to drop a patch in DLFW builds). |
|
/merge |
Proposes some small updates to match existing RAPIDS conventions for
ci/run_*scripts.run_ctests.sh, for use in devcontainer environment (similar to Add devcontainer fallback for C++ test location NVIDIA/cuml#7596)run_nvforest_pytests.shcan be called from other paths besides the root of the repo