Skip to content

Add devcontainer fallback for C++ test location - #210

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:release/26.10from
jameslamb:ci-scripts
Sep 9, 2026
Merged

Add devcontainer fallback for C++ test location#210
rapids-bot[bot] merged 1 commit into
rapidsai:release/26.10from
jameslamb:ci-scripts

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Proposes some small updates to match existing RAPIDS conventions for ci/run_* scripts.

@jameslamb
jameslamb requested a review from a team as a code owner September 3, 2026 21:12
@jameslamb
jameslamb requested a review from bdice September 3, 2026 21:12
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 3, 2026
@github-actions github-actions Bot added the ci label Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 214b2dab-ebf0-426c-b5f1-ac0ebc7d5a28

📥 Commits

Reviewing files that changed from the base of the PR and between 1962ef9 and 0ff197b.

📒 Files selected for processing (2)
  • ci/run_ctests.sh
  • ci/run_nvforest_pytests.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes

    • Improved test execution scripts to locate tests in configured installations or development builds, with clear errors when tests are unavailable.
    • Test scripts can now be run from outside their own directory without path-related failures.
  • Maintenance

    • Updated copyright information in the test runner.

Walkthrough

The CI scripts now locate CTest files through ordered path checks and fail clearly when no location exists. The pytest script now normalizes its working directory to the repository root before execution.

Changes

CI path handling

Layer / File(s) Summary
CTest location discovery
ci/run_ctests.sh
The script checks the configured or Conda-installed test path first, then the devcontainer build path. It reports both paths and exits with an error when neither path exists.
Pytest repository normalization
ci/run_nvforest_pytests.sh
The script changes to the repository root based on its resolved location before running pytest. The SPDX copyright range now covers 2025–2026.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 0ff19

CTest execution can now fall back to the devcontainer test location, and pytest invocation works outside the repository root. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description directly explains the devcontainer fallback and repository-root normalization changes.
Title check ✅ Passed The title clearly identifies the primary change: adding a devcontainer fallback for the C++ test location.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jameslamb
jameslamb changed the base branch from main to release/26.10 September 9, 2026 01:49
@jameslamb

Copy link
Copy Markdown
Member Author

I've retargeted this at 26.10. I would really like to get it in if possible (allows us to drop a patch in DLFW builds).

@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit e84059b into rapidsai:release/26.10 Sep 9, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants