Add support for Python 3.13 #131
Conversation
bdice
added
non-breaking
|
This can be merged as-is once CI passes, without committing the rest of RAPIDS to completing the Python 3.13 migration. The CI build and test matrices for pynvjitlink are independent of the rest of RAPIDS. |
| @@ -21,10 +21,10 @@ jobs: | |||
| - test-wheels | |||
| - test-patch | |||
| secrets: inherit | |||
| uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-24.10 | |||
| uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-25.04 | |||
There was a problem hiding this comment.
Should we figure out a better way to keep workflow references like these updated?
Understand doing this for pynvjitlink alone may not be worth it. However we have a few projects not following RAPIDS versioning that could benefit from a similar solution
There was a problem hiding this comment.
We have settled on doing these updates on an ad-hoc basis. I only changed them here because this PR was originally going to use the branch python-3.13 but it turned out that isn’t necessary because the CI build/test matrix for pynvjitlink is independent of the shared-workflows matrix. It felt more appropriate to update to the latest version rather than revert the changes.
| - python=3.13 | ||
| - matrix: | ||
| packages: | ||
| - python>=3.10,<3.14 |
There was a problem hiding this comment.
| - python>=3.10,<3.14 | |
| - python>=3.10,<3.14a0 |
There was a problem hiding this comment.
@jakirkham Do you have thoughts on how to coordinate this suggestion with the proposal to drop all alpha specs? rapidsai/build-planning#144
I am inclined to say we should leave this as-is, but I don’t have strong feelings.
There was a problem hiding this comment.
Suppose we could have a different pin for conda & pip
That said, given one needs to opt-in to use RCs from conda-forge. It doesn't seem like that big of a risk
|
Thanks Bradley! 🙏 |
Description
Contributes to rapidsai/build-planning#120
This PR adds support for Python 3.13.
Notes for Reviewers
This is part of ongoing work to add Python 3.13 support across RAPIDS.
This can be merged whenever all CI jobs are passing.