Skip to content

Fixed pytest marker warnings by removing unused pytest.ini #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

TomAugspurger
Copy link
Contributor

The CI for raft-dask includes warnings about unregistered pytest markers: https://github.com/rapidsai/raft/actions/runs/13394517078/job/37411078661#step:10:2656

../../../pyenv/versions/3.12.9/lib/python3.12/importlib/__init__.py:90
  /pyenv/versions/3.12.9/lib/python3.12/importlib/__init__.py:90: PytestUnknownMarkWarning: Unknown pytest.mark.mg - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    return _bootstrap._gcd_import(name[level:], package, level)

Those markers are registered here at the root of raft-dask, but a second pytest.ini in raft_dask/tests/pytest.ini shadowed that pytest.ini. Without the second pytest.ini, I don't see these warnings locally.

@TomAugspurger TomAugspurger requested a review from a team as a code owner February 21, 2025 17:29
@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 21, 2025
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for fixing @TomAugspurger !

@cjnolet cjnolet changed the base branch from branch-25.04 to branch-25.06 April 25, 2025 15:20
@cjnolet
Copy link
Member

cjnolet commented Apr 25, 2025

/ok to test 3d41ede

@cjnolet
Copy link
Member

cjnolet commented Apr 25, 2025

/merge

@rapids-bot rapids-bot bot merged commit 599f54f into rapidsai:branch-25.06 Apr 25, 2025
68 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in VS/ML/DM Primitives Release Board Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

3 participants