Lanczos Solver which=SA,SM,LA,LM argument
#2628
Conversation
aamijar
force-pushed
the
lanczos-solver-which-argument
branch
from
3585778 to
6327b2f
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aamijar
added
enhancement
| @@ -20,6 +20,8 @@ | |||
|
|
|||
| namespace raft::sparse::solver { | |||
|
|
|||
| enum LANCZOS_WHICH { LA, LM, SA, SM }; | |||
There was a problem hiding this comment.
Add documentation here on the meaning (smallest/largest - Algebraic/Magnitude)
| @@ -192,6 +205,15 @@ def eigsh(A, k=6, v0=None, ncv=None, maxiter=None, | |||
| config_float.ncv = ncv | |||
| config_float.tolerance = tol | |||
| config_float.seed = seed | |||
|
|
|||
| if which.lower() == "sa": | |||
There was a problem hiding this comment.
Factorize this if-else machine in a function to reuse
| @@ -100,7 +108,7 @@ cdef extern from "raft_runtime/solver/lanczos.hpp" \ | |||
|
|
|||
|
|
|||
| @auto_sync_handle | |||
| def eigsh(A, k=6, v0=None, ncv=None, maxiter=None, | |||
| def eigsh(A, k=6, which="SA", v0=None, ncv=None, maxiter=None, | |||
There was a problem hiding this comment.
The main use case for us is SA but the default param should be the same as cupy and scipy in order to match the API.
| auto sm_eigenvectors = | ||
| raft::make_device_matrix<ValueTypeT, uint32_t, raft::col_major>(handle, ncv, nEigVecs); | ||
|
|
||
| if (which == LANCZOS_WHICH::SA) { |
There was a problem hiding this comment.
Can this additional treatment of which happen in lanczos_solve_ritz? The current function is already long and this will follow more closely cupy's code architecture.
And lanczos_solve_ritz already accepts a which arguments that's unused right now.
(+ avoid code duplication)
| } | ||
|
|
||
| // Re-sort these indices by algebraic value to maintain algebraic ordering | ||
| thrust::sort(thrust::device, |
There was a problem hiding this comment.
cupy's version is doing only one argsort. Is this one absolutely necessary?
Resolves #2624
Resolves #2483