[FEA] Matrix column shift #2634
Open
+617
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsolp
added
enhancement
cjnolet
reviewed
Apr 23, 2025
cpp/include/raft/matrix/shift.cuh
Outdated
| * @param[in] k: shift size | ||
| */ | ||
| template <typename math_t, typename matrix_idx_t> | ||
| void col_right_shift(raft::resources const& handle, |
There was a problem hiding this comment.
This naming is a bit confusing. Could we please instead have a "shift" function with an enum for "Direction::Left", "Direction::Right" and maybe use another enum for ShiftType::Row/ShiftType::Column? That would clean this up and minimize the number of free functions the user has to worry about invoking.
There was a problem hiding this comment.
Thank you for the suggestion, totally agree.
We have towards_end and towards_zero as the shift direction because left/right doesn't work with row shifting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for in-place row or column shifting for matrices.
Currently needed for the case where we need to add a self loop in a knn graph.