[FEA] Matrix shift rows and columns #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsolp
added
enhancement
cjnolet
reviewed
Apr 23, 2025
cjnolet
reviewed
Apr 28, 2025
cjnolet
reviewed
Apr 28, 2025
cjnolet
reviewed
Apr 28, 2025
cpp/include/raft/matrix/shift.cuh
Outdated
| * @param[in] shift_type: ShiftType::ROW shifts rows and ShiftType::COL shift columns | ||
| */ | ||
| template <typename math_t, typename matrix_idx_t> | ||
| void shift_self(raft::resources const& handle, |
There was a problem hiding this comment.
Can we incorporate this as a specialized input into the prior functions so that we can avoid having a separate function just for this? Every template function we expose becomes another compiled kernel into the user's binary. The more we can consolidate, the better.
There was a problem hiding this comment.
val is now a nullopt. If not specified, we fill with row ids and column ids.
|
/ok to test |
|
/ok to test be95a4a |
cjnolet
reviewed
May 5, 2025
|
/ok to test 7f12f71 |
|
/merge |
|
/ok to test 3c52fba |
1 similar comment
|
/ok to test 3c52fba |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for in-place row or column shifting for matrices.
Supports the following shift-then-fill
Has the following options
ShiftDirection: can shift towards the beginning (left for columns, top for rows) or the end (right for columns, bottom for rows).ShiftType: either row or columnCurrently needed for the case where we need to add a self loop in a knn graph.