write_language: Disables hook when CMP0220 is set to NEW - #1072
Open
arhag23 wants to merge 5 commits into
Open
Conversation
robertmaynard
added
feature request
robertmaynard
approved these changes
Aug 13, 2026
In CMake 4.5 and above, the policy CMP0220 controls whether enable_language will propagate into the current subdirectory/scope. We need to update the logic so that if this policy exists and is set that write_language does nothing since enable_language takes care of everything for us. Please enter the commit message for your changes. Lines starting
arhag23
force-pushed
the
write-language-policy
branch
from
August 14, 2026 22:28
11b166d to
bfde838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that
enable_languagesupport in subdirectories has been merged to CMake upstream,rapids_export_write_languagedoes not need to use its hook logic when the CMake policyCMP0220is set toNEW. Now simply callingenable_languageis sufficient to get the behavior ofwrite_language.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))