In conda-build produced binaries, use paths relative to $PREFIX
#817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
improvement
jakirkham
force-pushed
the
chng_gcc_prefix_pth
branch
4 times, most recently
from
16ec700 to
6b0988a
Compare
jakirkham
force-pushed
the
chng_gcc_prefix_pth
branch
from
6b0988a to
9a899aa
Compare
KyleFromNVIDIA
approved these changes
Apr 8, 2025
|
Thanks Kyle! 🙏 @vyasr would you like to take a look as well? |
3 tasks
|
Is it possible to test this? |
|
Is there a way to checkout this PR in a build of say RMM or cuDF? If so, we could use that to test this change in downstream CI |
This was referenced Apr 16, 2025
vyasr
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
LGTM. One very minor suggestion but nothing blocking. I just merged latest so that I could rerun CI on the test PRs since this PR is now out of date w.r.t. the rmm layout changes, so the cudf test job is failing. Once it passes we should be good.
robertmaynard
requested changes
Apr 17, 2025
jakirkham
commented
Apr 17, 2025
jakirkham
commented
Apr 19, 2025
Comment on lines
+44
to
+50
| .. versionadded:: v25.06.00 | ||
|
|
||
| The flag `-ffile-prefix-map` is now passed to remap absolute paths starting | ||
| with `$ENV{PREFIX}` to paths relative to it in binaries generated via | ||
| compilation. This ensures paths baked into binaries are relative to the | ||
| environment prefix. This prevents Conda from rewriting these paths when the | ||
| package is installed. |
There was a problem hiding this comment.
How about this revision?
jakirkham
changed the title
$PREFIX in conda-build$PREFIX
bdice
approved these changes
Apr 20, 2025
robertmaynard
approved these changes
Apr 21, 2025
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #798
Add compiler flags in conda-build runs to remap binary embedded paths from absolute paths (with
$PREFIX) to$PREFIXrelative paths. This keeps the meaningful portion of the path while dropping the build time specific$PREFIX. Plus bypasses the need to do prefix replacement with these paths.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))