Create PackedData from cudf PackedColumns #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirandaperera
added
improvement
wence-
reviewed
Apr 25, 2025
Comment on lines
19
to
22
| def __init__(self, PackedColumns packed_columns) -> None: | ||
| self.c_obj = make_unique[cpp_PackedData]( | ||
| move(deref(packed_columns.c_obj).metadata), | ||
| move(deref(packed_columns.c_obj).gpu_data)) |
There was a problem hiding this comment.
This needs to very clearly document that it takes ownership of the data in the passed in PackedColumns object.
|
/ok to test |
madsbk
requested changes
Apr 28, 2025
Co-authored-by: Mads R. B. Kristensen <[email protected]>
madsbk
requested changes
Apr 29, 2025
| @@ -13,3 +15,39 @@ cdef class PackedData: | |||
| cdef PackedData self = PackedData.__new__(PackedData) | |||
| self.c_obj = move(obj) | |||
| return self | |||
|
|
|||
| @staticmethod | |||
| def from_cudf_packed_columns(PackedColumns packed_columns) -> PackedData: | |||
There was a problem hiding this comment.
No type notation in pyx
Suggested change
| def from_cudf_packed_columns(PackedColumns packed_columns) -> PackedData: | |
| def from_cudf_packed_columns(PackedColumns packed_columns): |
| @@ -13,3 +15,39 @@ cdef class PackedData: | |||
| cdef PackedData self = PackedData.__new__(PackedData) | |||
| self.c_obj = move(obj) | |||
| return self | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
Make it a @classmethod and do cls.__new__(cls) like in the spill manager: https://github.com/rapidsai/rapidsmpf/blob/b77ed56a56a357d4e1f1bcb6208098a8078fb740/python/rapidsmpf/rapidsmpf/buffer/spill_manager.pyx#L95C33
Co-authored-by: Mads R. B. Kristensen <[email protected]>
Signed-off-by: niranda perera <[email protected]>
…ra/rapidsmpf into packed_data_from_packed_cols
pentschev
reviewed
May 9, 2025
| class PackedData: | ||
| pass | ||
| def __init__(self) -> None: ... | ||
| @staticmethod |
There was a problem hiding this comment.
Should this be @classmethod like in the pyx file?
There was a problem hiding this comment.
yes, good catch. Thanks @pentschev
Co-authored-by: Peter Andreas Entschev <[email protected]>
Signed-off-by: niranda perera <[email protected]>
…ra/rapidsmpf into packed_data_from_packed_cols
Signed-off-by: niranda perera <[email protected]>
pentschev
approved these changes
May 10, 2025
madsbk
requested changes
May 12, 2025
| """ | ||
| cdef PackedData ret = cls.__new__(cls) | ||
| with nogil: | ||
| if not (deref(packed_columns.c_obj).metadata and |
There was a problem hiding this comment.
Also check that packed_columns.c_obj isn't null
Signed-off-by: niranda perera <[email protected]>
madsbk
approved these changes
May 13, 2025
Co-authored-by: Mads R. B. Kristensen <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PackedData cython API does not contain a constructor that takes in cudf packed columns. This PR adds it.