Skip to content

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 20, 2025

Description

This pragma is a workaround for cudf build issues, see e.g. https://github.com/rapidsai/cudf/actions/runs/20384141895/job/58581416851?pr=20929. The thrust allocator class needs to be reworked eventually anyway due to the upstream allocator being deprecated, so this workaround is acceptable for now. I'm entirely confused as to why this line is where the suppression is needed and I suspect that this is a completely false diagnostic from nvcc, but for now I think it's acceptable to add this as a workaround to get builds passing. I verified that this fixes cudf builds in a local devcontainer reproducing the issue.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Dec 20, 2025
@vyasr vyasr requested a review from a team as a code owner December 20, 2025 17:40
@vyasr vyasr added the non-breaking Non-breaking change label Dec 20, 2025
@vyasr vyasr requested review from bdice and davidwendt December 20, 2025 17:40
@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Dec 20, 2025
@vyasr vyasr mentioned this pull request Dec 20, 2025
3 tasks
@bdice
Copy link
Contributor

bdice commented Dec 20, 2025

/merge

@rapids-bot rapids-bot bot merged commit dc22feb into main Dec 20, 2025
81 checks passed
@bdice
Copy link
Contributor

bdice commented Dec 20, 2025

Opened #2193 as a follow-up investigation.

@vyasr vyasr deleted the fix/thrust_adaptor_warning branch December 21, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants