test: isolate library wheel smoke test - #2494
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test a9245e6 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe wheel test script updates its SPDX header and adds isolated ChangesWheel validation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/test_wheel.sh`:
- Line 25: Update the Python validation command in ci/test_wheel.sh to
explicitly assert that librmm.load_library() succeeds rather than relying on its
return code; fail the command when the function returns None, while preserving
successful execution for a loaded native library.
- Line 17: Update the virtual-environment setup in ci/test_wheel.sh to use
python -m venv --clear librmm-env, preventing stale packages across reruns. In
the native-load validation command, explicitly assert that librmm.load_library()
returns a valid handle so a None result causes a nonzero exit status.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 624b1c83-073c-4917-a111-41c6088bed0a
📒 Files selected for processing (1)
ci/test_wheel.sh
|
/ok to test 56647ad |
|
/ok to test f4ff4fc |
Description
Install the library wheel in a clean virtual environment and call its
load_library()entry point before installing the high-level wheel or test extras. This exposes missing library-wheel runtime dependencies that the full test environment can otherwise mask.xref: rapidsai/build-planning#307