Skip to content

Replace <cuda/stream_ref> includes with <cuda/stream> - #2513

Merged
rapids-bot[bot] merged 2 commits into
mainfrom
cursor/switch-cuda-stream-include-43dc
Aug 14, 2026
Merged

Replace <cuda/stream_ref> includes with <cuda/stream>#2513
rapids-bot[bot] merged 2 commits into
mainfrom
cursor/switch-cuda-stream-include-43dc

Conversation

@bdice

@bdice bdice commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Description

CCCL deprecated the <cuda/stream_ref> header; cuda::stream_ref is now provided by <cuda/stream>. This PR switches every #include <cuda/stream_ref> to #include <cuda/stream> so RMM builds against newer CCCL.

The cuda::stream_ref type is unchanged. This was observed in rapids-cmake CI: https://github.com/rapidsai/rapids-cmake/actions/runs/31745925779/job/94600794610?pr=1073

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Slack Thread

Open in Web Open in Cursor 

CCCL deprecated the <cuda/stream_ref> header; cuda::stream_ref now lives in <cuda/stream>. Switch all includes so RMM builds against newer CCCL.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bdice
bdice marked this pull request as ready for review August 14, 2026 15:52
@bdice
bdice requested a review from a team as a code owner August 14, 2026 15:52
@bdice
bdice requested review from harrism and rongou August 14, 2026 15:52
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73e82212-e27b-4f7e-8de0-cbf086d6d5f6

📥 Commits

Reviewing files that changed from the base of the PR and between 25334e0 and 84fefef.

📒 Files selected for processing (5)
  • cpp/benchmarks/utilities/simulated_memory_resource.hpp
  • cpp/tests/cuda_stream_tests.cpp
  • cpp/tests/device_check_resource_adaptor.hpp
  • cpp/tests/mock_resource.hpp
  • cpp/tests/mr/failure_callback_mr_tests.cpp
🚧 Files skipped from review as they are similar to previous changes (5)
  • cpp/tests/device_check_resource_adaptor.hpp
  • cpp/tests/mock_resource.hpp
  • cpp/tests/mr/failure_callback_mr_tests.cpp
  • cpp/benchmarks/utilities/simulated_memory_resource.hpp
  • cpp/tests/cuda_stream_tests.cpp

📝 Walkthrough

Summary by CodeRabbit

  • Maintenance
    • Updated CUDA stream header usage throughout the library, benchmarks, and tests.
    • Improved compatibility with current CUDA headers without changing public APIs or runtime behavior.

Walkthrough

The pull request replaces <cuda/stream_ref> with <cuda/stream> across RMM headers, implementations, benchmark utilities, and tests. It also updates selected copyright notices. No declarations or runtime logic change.

Changes

CUDA stream header migration

Layer / File(s) Summary
Public and internal header dependencies
cpp/include/rmm/...
RMM headers now include <cuda/stream> instead of <cuda/stream_ref>.
Implementation dependencies
cpp/src/...
RMM source files now include <cuda/stream> without changing implementation logic.
Benchmark and test dependencies
cpp/benchmarks/..., cpp/tests/...
Benchmark utilities and tests now include <cuda/stream>. Selected copyright notices now include updated attribution or years.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 84fef

This change only updates deprecated CUDA header includes while preserving the existing stream type; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

  • rapidsai/rmm#2511: Shares CUDA stream files, but adds stream-detection and batched-copy functionality.

Suggested reviewers: harrism, rongou

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: replacing deprecated CUDA stream header includes.
Description check ✅ Passed The description directly explains the header replacement, its CCCL compatibility purpose, and the unchanged cuda::stream_ref type.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/switch-cuda-stream-include-43dc

Comment @coderabbitai help to get the list of available commands.

@bdice bdice self-assigned this Aug 14, 2026
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 14, 2026
@bdice

bdice commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 25334e0

@bdice

bdice commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

pre-commit.ci autofix

verify-copyright requires "NVIDIA CORPORATION & AFFILIATES. All rights reserved."
on files touched by this PR.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@bdice

bdice commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 84fefef

@bdice

bdice commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit f2a7674 into main Aug 14, 2026
90 checks passed
rapids-bot Bot pushed a commit to NVIDIA/cudf that referenced this pull request Aug 15, 2026
CCCL deprecated the `<cuda/stream_ref>` header; `cuda::stream_ref` is now provided by `<cuda/stream>`. This PR switches every `#include <cuda/stream_ref>` to `#include <cuda/stream>` so libcudf builds against newer CCCL.

Rebased onto main after #23649 (`Use cuda::stream_ref for compute APIs`) so the additional includes from that migration are covered as well. Also drops a duplicate `<cuda/stream>` include in `top_k.cu` that the rename introduced.

The `cuda::stream_ref` type is unchanged. This matches the same change in RMM (rapidsai/rmm#2513) and was observed in rapids-cmake CI: https://github.com/rapidsai/rapids-cmake/actions/runs/31745925779/job/94600794610?pr=1073

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Cursor Agent (https://github.com/cursoragent)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #23664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants