Replace <cuda/stream_ref> includes with <cuda/stream> - #2513
Conversation
CCCL deprecated the <cuda/stream_ref> header; cuda::stream_ref now lives in <cuda/stream>. Switch all includes so RMM builds against newer CCCL. Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request replaces ChangesCUDA stream header migration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only updates deprecated CUDA header includes while preserving the existing stream type; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
/ok to test 25334e0 |
|
pre-commit.ci autofix |
verify-copyright requires "NVIDIA CORPORATION & AFFILIATES. All rights reserved." on files touched by this PR. Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
/ok to test 84fefef |
|
/merge |
CCCL deprecated the `<cuda/stream_ref>` header; `cuda::stream_ref` is now provided by `<cuda/stream>`. This PR switches every `#include <cuda/stream_ref>` to `#include <cuda/stream>` so libcudf builds against newer CCCL. Rebased onto main after #23649 (`Use cuda::stream_ref for compute APIs`) so the additional includes from that migration are covered as well. Also drops a duplicate `<cuda/stream>` include in `top_k.cu` that the rename introduced. The `cuda::stream_ref` type is unchanged. This matches the same change in RMM (rapidsai/rmm#2513) and was observed in rapids-cmake CI: https://github.com/rapidsai/rapids-cmake/actions/runs/31745925779/job/94600794610?pr=1073 Authors: - Bradley Dice (https://github.com/bdice) - Cursor Agent (https://github.com/cursoragent) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #23664
Description
CCCL deprecated the
<cuda/stream_ref>header;cuda::stream_refis now provided by<cuda/stream>. This PR switches every#include <cuda/stream_ref>to#include <cuda/stream>so RMM builds against newer CCCL.The
cuda::stream_reftype is unchanged. This was observed in rapids-cmake CI: https://github.com/rapidsai/rapids-cmake/actions/runs/31745925779/job/94600794610?pr=1073Checklist
Slack Thread