Turtlesim shared lib #512
Merged
Turtlesim shared lib #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bers for WaitForMsg and WaitForTrigger
…e interface base class
Collaborator
|
Is it in a runnable state? When I try to run tests it says it cannot find the master plan |
The dynamic creators maintain a reference to the currently loaded symbol, therefore dlls that were loaded prior would no longer be loaded & accessing such dlls (typically in the destructor of the beh/plan etc) would cause undefined behaviour. Specifically this lead to a crash in the destructor of the GoTo behaviour in turtlesim. Such crashes are hard to debug & can occur in more ways due to this issue. As a fix, the creator for each symbol is stored for the lifetime of the dynamic creator object itself which is basically the entire duration of the engine. Consequently the symbol & dll is loaded just once potentially improving performance.
Contributor
Author
|
@bjoernschroeder @veerajsk seems everything works now |
veerajsk
approved these changes
Nov 2, 2023
bjoernschroeder
approved these changes
Nov 2, 2023
| #include "turtle_interfaces.hpp" | ||
| #include "alica_ros_turtlesim/turtle_ros1_interfaces.hpp" | ||
|
|
||
| #include <engine/blackboard/Blackboard.h> |
Collaborator
There was a problem hiding this comment.
seems like its not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizing and reattempting #502, with upcoming placeholders feature in mind.
Base package alica_turtlesim with all base plans. Ros turtlesim package adds a couple new libraries and plugs them in. Both are loaded and combined to get the full plan.