Skip to content

support 128 bit integers#100

Merged
tayloraswift merged 2 commits intomasterfrom
support-128-bit
Jan 21, 2026
Merged

support 128 bit integers#100
tayloraswift merged 2 commits intomasterfrom
support-128-bit

Conversation

@tayloraswift
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tayloraswift, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for 128-bit integers (Int128 and UInt128) within the JSON encoding and decoding framework. It modifies the JSON.Number type to accommodate larger integer values by falling back to a string representation when necessary. Additionally, it includes updates to the testing suite to ensure the correct handling of these larger integer types, as well as marking some initializers as deprecated.

Highlights

  • Int128 Support: Adds Int128 and UInt128 types to the JSON encoding and decoding conformances, allowing for larger integer values to be represented in JSON.
  • JSON.Number Improvements: Modifies JSON.Number to handle larger integer values by using a fallback to string representation when the value exceeds the capacity of UInt64.
  • Deprecation: Marks the JSON.Number.Inline initializer as deprecated, recommending direct initialization of JSON.Number instead.
  • Test Updates: Updates IntegerOverflow tests to use throws and adds new tests for Int128 and UInt128 roundtripping.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for 128-bit integers by adding a fallback mechanism to store large numbers as strings, which is a robust approach. The implementation is well-executed, with corresponding updates to initializers and conversion methods. The accompanying tests are thorough, covering new Int128 and UInt128 types, including round-tripping and overflow scenarios. Additionally, there are numerous stylistic improvements that enhance code conciseness. I have a couple of minor suggestions to further improve code clarity.

@tayloraswift tayloraswift merged commit 89c6c3e into master Jan 21, 2026
8 checks passed
@tayloraswift tayloraswift deleted the support-128-bit branch January 21, 2026 02:32
tayloraswift added a commit that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant