encode jsobject

Package.swift

@@ -9,6 +9,8 @@ let package: Package = .init(
         .library(name: "JSONAST", targets: ["JSONAST"]),
         .library(name: "JSONLegacy", targets: ["JSONLegacy"]),
         .library(name: "JavaScriptPersistence", targets: ["JavaScriptPersistence"]),
+
+        .library(name: "_JSON_SnippetsAnchor", targets: ["_JSON_SnippetsAnchor"]),
     ],
     dependencies: [
         .package(url: "https://github.com/tayloraswift/swift-grammar", from: "0.5.0"),
@@ -69,6 +71,18 @@ let package: Package = .init(
                 .target(name: "JSON"),
             ]
         ),
+
+
+        .target(
+            name: "_JSON_SnippetsAnchor",
+            dependencies: [
+                .target(name: "JSON"),
+            ],
+            path: "Snippets/_Anchor",
+            linkerSettings: [
+                .linkedLibrary("m"),
+            ],
+        ),
     ]
 )
 package.targets = package.targets.map {

Snippets/_Anchor/anchor.swift

@@ -0,0 +1,3 @@
+/// This target functions as an anchor to remind SwiftPM to link `libm` before trying to compile
+/// snippets. Without it, there would be no attachment point for the linker settings, unless we
+/// were to dirty the actual library targets with snippet-specific settings

Sources/JSONAST/JSON.Node.swift

@@ -19,18 +19,6 @@ extension JSON {
         case object(Object)
     }
 }
-
-extension String {
-    init(_ literal: JSON.Literal<String>) {
-        var json: JSON = .init(utf8: [])
-
-        json.utf8.reserveCapacity(literal.value.utf8.count + 2)
-        json += literal
-
-        self.init(decoding: json.utf8, as: Unicode.UTF8.self)
-    }
-}
-
 extension JSON.Node {
     // TODO: optimize this, it should operate at the utf8 level, and be @inlinable
 

Sources/JSONAST/JSON.Number.Inline.swift

@@ -10,7 +10,7 @@ extension JSON.Number {
         /// The sign of this numeric literal.
         public var sign: FloatingPointSign
         // cannot have an inlinable property wrapper
-        @usableFromInline internal var _places: UInt32
+        @usableFromInline var _places: UInt32
         /// The number of decimal places this numeric literal has.
         ///
         /// >   Note:

Sources/JSONAST/String (ext).swift

@@ -0,0 +1,10 @@
+extension String {
+    init(_ literal: JSON.Literal<String>) {
+        var json: JSON = .init(utf8: [])
+
+        json.utf8.reserveCapacity(literal.value.utf8.count + 2)
+        json += literal
+
+        self.init(decoding: json.utf8, as: Unicode.UTF8.self)
+    }
+}

Sources/JSONDecoding/Conformances/Array (ext).swift

@@ -1,10 +1,10 @@
 extension Array: JSONDecodable where Element: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         try self.init(json: try .init(json: json))
     }
 }
 extension Array where Element: JSONDecodable {
-    @inlinable public init(json: JSON.Array) throws {
+    @inlinable public init(json: borrowing JSON.Array) throws {
         self = try json.map { try $0.decode(to: Element.self) }
     }
 }

Sources/JSONDecoding/Conformances/Bool (ext).swift

@@ -1,5 +1,5 @@
 extension Bool: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { $0.as(Self.self) }
     }
 }

Sources/JSONDecoding/Conformances/Character (ext).swift

@@ -7,7 +7,7 @@ extension Character: JSONStringDecodable {
     /// witness traps on invalid input instead of returning nil, which
     /// causes its default implementation (where `Self: LosslessStringConvertible`)
     /// to do the same.
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         let string: String = try .init(json: json)
         if  string.startIndex < string.endIndex,
             string.index(after: string.startIndex) == string.endIndex {

Sources/JSONDecoding/Conformances/Dictionary (ext).swift

@@ -2,12 +2,12 @@ extension Dictionary: JSONDecodable where Key == String, Value: JSONDecodable {
     /// Decodes an unordered dictionary from the given document. Dictionaries
     /// are not ``JSONEncodable``, because round-tripping them loses the field
     /// ordering information.
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         try self.init(json: try .init(json: json))
     }
-    @inlinable public init(json: JSON.Object) throws {
+    @inlinable public init(json: borrowing JSON.Object) throws {
         self.init(minimumCapacity: json.count)
-        for field: JSON.FieldDecoder<String> in json {
+        for field: JSON.FieldDecoder<String> in copy json {
             if case _? = self.updateValue(try field.decode(to: Value.self), forKey: field.key) {
                 throw JSON.ObjectKeyError<String>.duplicate(field.key)
             }

Sources/JSONDecoding/Conformances/Double (ext).swift

@@ -1,5 +1,5 @@
 extension Double: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { $0.as(Self.self) }
     }
 }

Sources/JSONDecoding/Conformances/Float (ext).swift

@@ -1,5 +1,5 @@
 extension Float: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { $0.as(Self.self) }
     }
 }

Sources/JSONDecoding/Conformances/Float16 (ext).swift

@@ -1,6 +1,6 @@
 @available(macOS 11.0, iOS 14.0, tvOS 14.0, watchOS 7.0, *)
 extension Float16: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { $0.as(Self.self) }
     }
 }

Sources/JSONDecoding/Conformances/Float80 (ext).swift

@@ -1,6 +1,6 @@
 #if (os(Linux) || os(macOS)) && arch(x86_64)
 extension Float80: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { $0.as(Self.self) }
     }
 }

Sources/JSONDecoding/Conformances/Set (ext).swift

@@ -1,5 +1,5 @@
 extension Set: JSONDecodable where Element: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         let array: JSON.Array = try .init(json: json)
 
         self.init()

Sources/JSONDecoding/Conformances/String (ext).swift

@@ -1,5 +1,5 @@
 extension String: JSONStringDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { $0.as(String.self) }
     }
 }

Sources/JSONDecoding/Decoding/JSON.ObjectDecoder.swift

@@ -11,14 +11,14 @@ extension JSON {
     }
 }
 extension JSON.ObjectDecoder: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         try self.init(indexing: try .init(json: json))
     }
 }
 extension JSON.ObjectDecoder where CodingKey: RawRepresentable<String> {
-    @inlinable public init(indexing object: JSON.Object) throws {
+    @inlinable public init(indexing object: borrowing JSON.Object) throws {
         self.init(.init(minimumCapacity: object.count))
-        for field: JSON.FieldDecoder<String> in object {
+        for field: JSON.FieldDecoder<String> in copy object {
             guard let key: CodingKey = .init(rawValue: field.key) else {
                 continue
             }

Sources/JSONDecoding/JSON.Array (ext).swift

@@ -15,7 +15,7 @@ extension JSON.Array: RandomAccessCollection {
     }
 }
 extension JSON.Array: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast(with: \.array)
     }
 }

Sources/JSONDecoding/JSON.Object (ext).swift

@@ -11,7 +11,7 @@ extension JSON.Object: RandomAccessCollection {
     }
 }
 extension JSON.Object: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast(with: \.object)
     }
 }

Sources/JSONDecoding/JSONDecodable.swift

@@ -3,20 +3,20 @@ public protocol JSONDecodable {
     /// Attempts to cast a JSON variant backed by some storage type to an
     /// instance of this type. The implementation can copy the contents
     /// of the backing storage if needed.
-    init(json: JSON.Node) throws
+    init(json: borrowing JSON.Node) throws
 }
 extension JSONDecodable where Self: SignedInteger & FixedWidthInteger {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { try $0.as(Self.self) }
     }
 }
 extension JSONDecodable where Self: UnsignedInteger & FixedWidthInteger {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         self = try json.cast { try $0.as(Self.self) }
     }
 }
 extension JSONDecodable where Self: RawRepresentable, RawValue: JSONDecodable & Sendable {
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         let rawValue: RawValue = try .init(json: json)
         if  let value: Self = .init(rawValue: rawValue) {
             self = value

Sources/JSONDecoding/JSONObjectDecodable.swift

@@ -2,13 +2,13 @@
 public protocol JSONObjectDecodable<CodingKey>: JSONDecodable {
     associatedtype CodingKey: RawRepresentable<String> & Hashable & Sendable = JSON.Key
 
-    init(json: JSON.ObjectDecoder<CodingKey>) throws
+    init(json: borrowing JSON.ObjectDecoder<CodingKey>) throws
 }
 extension JSONObjectDecodable {
-    @inlinable public init(json: JSON.Object) throws {
+    @inlinable public init(json: borrowing JSON.Object) throws {
         try self.init(json: try .init(indexing: json))
     }
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         try self.init(json: try .init(json: json))
     }
 }

Sources/JSONDecoding/JSONStringDecodable.swift

@@ -16,7 +16,7 @@ extension JSONStringDecodable {
     /// itself to prevent unexpected behavior for types (such as ``Int``)
     /// who implement ``LosslessStringConvertible``, but expect to be
     /// decoded from a variant value that is not a string.
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         let string: String = try .init(json: json)
         if  let value: Self = .init(string) {
             self = value

Sources/JSONDecoding/Never (ext).swift

@@ -1,6 +1,6 @@
 extension Never: JSONDecodable {
     /// Always throws a ``JSON.TypecastError``.
-    @inlinable public init(json: JSON.Node) throws {
+    @inlinable public init(json: borrowing JSON.Node) throws {
         throw JSON.TypecastError<Never>.init(invalid: json)
     }
 }

Sources/JSONDecoding/Optional (ext).swift

@@ -1,6 +1,6 @@
 extension Optional: JSONDecodable where Wrapped: JSONDecodable {
-    @inlinable public init(json: JSON.Node) throws {
-        if  case .null = json {
+    @inlinable public init(json: borrowing JSON.Node) throws {
+        if  case .null = copy json {
             self = .none
         } else {
             self = .some(try .init(json: json))

Sources/JSONEncoding/Conformances/Array (ext).swift

@@ -1,9 +1,3 @@
 extension Array: JSONEncodable where Element: JSONEncodable {
-    @inlinable public func encode(to json: inout JSON) {
-        {
-            for element: Element in self {
-                $0[+] = element
-            }
-        } (&json[as: JSON.ArrayEncoder.self])
-    }
+    @inlinable public func encode(to json: inout JSON) { self.encodeElements(to: &json) }
 }

Sources/JSONEncoding/Conformances/ArraySlice (ext).swift

@@ -1,9 +1,3 @@
 extension ArraySlice: JSONEncodable where Element: JSONEncodable {
-    @inlinable public func encode(to json: inout JSON) {
-        {
-            for element: Element in self {
-                $0[+] = element
-            }
-        } (&json[as: JSON.ArrayEncoder.self])
-    }
+    @inlinable public func encode(to json: inout JSON) { self.encodeElements(to: &json) }
 }

Sources/JSONEncoding/Conformances/LazyDropWhileSequence (ext).swift

@@ -0,0 +1,3 @@
+extension LazyDropWhileSequence: JSONEncodable where Element: JSONEncodable {
+    @inlinable public func encode(to json: inout JSON) { self.encodeElements(to: &json) }
+}

Sources/JSONEncoding/Conformances/LazyFilterSequence (ext).swift

@@ -0,0 +1,3 @@
+extension LazyFilterSequence: JSONEncodable where Element: JSONEncodable {
+    @inlinable public func encode(to json: inout JSON) { self.encodeElements(to: &json) }
+}

Sources/JSONEncoding/Conformances/LazyMapSequence (ext).swift

@@ -0,0 +1,3 @@
+extension LazyMapSequence: JSONEncodable where Element: JSONEncodable {
+    @inlinable public func encode(to json: inout JSON) { self.encodeElements(to: &json) }
+}

Sources/JSONEncoding/Conformances/LazyPrefixWhileSequence (ext).swift

@@ -0,0 +1,3 @@
+extension LazyPrefixWhileSequence: JSONEncodable where Element: JSONEncodable {
+    @inlinable public func encode(to json: inout JSON) { self.encodeElements(to: &json) }
+}

Sources/JSONEncoding/Conformances/Sequence (ext).swift

@@ -0,0 +1,11 @@
+extension Sequence where Self: JSONEncodable, Element: JSONEncodable {
+    // this does not directly witness the requirement, we don’t want it to show up on
+    // ``String``, for instance
+    @inlinable func encodeElements(to json: inout JSON) {
+        {
+            for element: Element in self {
+                $0[+] = element
+            }
+        } (&json[as: JSON.ArrayEncoder.self])
+    }
+}

Sources/JSONEncoding/Encoders/JSON.ArrayEncoder.swift

@@ -2,22 +2,22 @@ import JSONAST
 
 extension JSON {
     @frozen public struct ArrayEncoder: Sendable {
-        @usableFromInline internal var first: Bool
-        @usableFromInline internal var json: JSON
+        @usableFromInline var first: Bool
+        @usableFromInline var json: JSON
 
-        @inlinable internal init(json: JSON) {
+        @inlinable init(json: JSON) {
             self.first = true
             self.json = json
         }
     }
 }
 extension JSON.ArrayEncoder: JSON.InlineEncoder {
-    @inlinable internal static func move(_ json: inout JSON) -> Self {
+    @inlinable static func move(_ json: inout JSON) -> Self {
         json.utf8.append(0x5B) // '['
         defer { json.utf8 = [] }
         return .init(json: json)
     }
-    @inlinable internal mutating func move() -> JSON {
+    @inlinable mutating func move() -> JSON {
         self.first = true
         self.json.utf8.append(0x5D) // ']'
         defer { self.json.utf8 = [] }

Sources/JSONEncoding/Encoders/JSON.Literal (ext).swift

@@ -2,26 +2,26 @@ import JSONAST
 
 extension JSON.Literal<Never?> {
     /// Encodes `null` to the provided JSON stream.
-    @inlinable internal static func += (json: inout JSON, self: Self) {
+    @inlinable static func += (json: inout JSON, self: Self) {
         json.utf8 += "null".utf8
     }
 }
 extension JSON.Literal<Bool> {
     /// Encodes `true` or `false` to the provided JSON stream.
-    @inlinable internal static func += (json: inout JSON, self: Self) {
+    @inlinable static func += (json: inout JSON, self: Self) {
         json.utf8 += (self.value ? "true" : "false").utf8
     }
 }
 extension JSON.Literal where Value: BinaryInteger {
     /// Encodes this literal’s integer ``value`` to the provided JSON stream. The value’s
     /// ``CustomStringConvertible description`` witness must format the value in base-10.
-    @inlinable internal static func += (json: inout JSON, self: Self) {
+    @inlinable static func += (json: inout JSON, self: Self) {
         json.utf8 += self.value.description.utf8
     }
 }
 extension JSON.Literal where Value: BinaryFloatingPoint & LosslessStringConvertible {
     /// Encodes this literal’s floating-point ``value`` to the provided JSON stream.
-    @inlinable internal static func += (json: inout JSON, self: Self) {
+    @inlinable static func += (json: inout JSON, self: Self) {
         if  self.value.isSignalingNaN {
             json.utf8 += "snan".utf8
         } else if self.value.isNaN {