Conform floating points to JSONEncodable & JSONDecodable#92
Closed
rgoldberg wants to merge 2 commits intorarestype:masterfrom
Closed
Conform floating points to JSONEncodable & JSONDecodable#92rgoldberg wants to merge 2 commits intorarestype:masterfrom
JSONEncodable & JSONDecodable#92rgoldberg wants to merge 2 commits intorarestype:masterfrom
Conversation
Contributor
Author
|
@tayloraswift Need I make any changes to get this PR approved? Thanks. |
Member
|
i am concerned about adding a type that is Encode-only, and cannot be losslessly roundtripped |
Contributor
Author
|
If I also conformed floating points to Or would the limitations of acceptable values for Swift floating points prevent you from accepting it? |
rgoldberg
force-pushed
the
91-JSONEncodable-floating-points
branch
from
a5f7669 to
ad67fe5
Compare
rgoldberg
changed the title
JSONEncodableJSONEncodable & JSONDecodable
Contributor
Author
|
@tayloraswift I've redone how floating points are conformed to |
…unds from `BinaryInteger` to `Numeric & CustomStringConvertible` for `JSON.Literal where Value:` & `JSONEncodable where Self:`. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com> Support floating point encoding by changing extension generic type bounds from `BinaryInteger` to `Numeric & CustomStringConvertible` for `JSON.Literal where Value:` & `JSONEncodable where Self:`. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
91-JSONEncodable-floating-points
branch
from
c6c930e to
76a8b9d
Compare
Member
|
i used this as a starting point for #98 , which implements the underlying feature thank you for pushing for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conform floating points to
JSONEncodable.Resolve #91