Fix incorrect R2 * -1 in "Example 4 – Regression and Adjusted R2" print() examples and modernize f-strings #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Copilot finished reviewing on behalf of
sachinn854
December 3, 2025 08:04
There was a problem hiding this comment.
Pull request overview
This PR fixes documentation issues in Example 4 of the ExhaustiveFeatureSelector notebook by correcting incorrect R² score handling and modernizing code formatting.
Key changes:
- Removed erroneous multiplication by -1 when printing R² scores
- Modernized string formatting from old-style to f-strings
- Added explicit int casting for
num_examplescalculation to ensure correctness
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainer 👋
This PR updates the documentation in Example 4:
✅ Removed incorrect R² multiplication by −1 in print() examples
✅ Fixed reused/incorrect code from the previous example
✅ Modernized old-style string formatting to f-strings for clarity
✅ Optional: Casted num_examples to int for correctness & readability
Fixes #1118
All changes were verified locally for syntax & output correctness.
Let me know if any further improvement is needed.
Thanks! 🚀