Fix #717: Corrected PCA sign flip and updated test compatibility for … #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariam851
force-pushed
the
fix-pca-sign-717
branch
3 times, most recently
from
69988de to
f812c9d
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mariam851
force-pushed
the
fix-pca-sign-717
branch
from
f812c9d to
578b79f
Compare
… for Python 3.12
mariam851
force-pushed
the
fix-pca-sign-717
branch
from
578b79f to
7e24ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rasbt,
I've fixed issue #717 regarding the sign flip in plot_pca_correlation_graph. The correlation matrix now correctly aligns with feature variance.
Key Changes:
Logic: Inverted correlation signs to ensure consistent direction (e.g., positive correlations for Iris features).
Compatibility: Fixed a TypeError in test_pca_corr_graph.py related to Python 3.12 version comparison.
Formatting: Cleaned up both files with isort and flake8.
update: I've implemented the fix and ensured that my contributed files are properly formatted. However, the Linting CI is failing due to existing formatting issues in external files (adjust_text.py, association_rules.py, etc.) which seem to require a different version of black/isort than the one available in my environment. I've focused the changes on the PCA issue to keep the PR clean."