This repository was archived by the owner on Nov 28, 2023. It is now read-only.
.env file saving proccess abstractization#196
Open
pricop wants to merge 1 commit intorashidlaasri:masterfrom
pricop:Improve-file-saving-error-reporting
Open
.env file saving proccess abstractization#196pricop wants to merge 1 commit intorashidlaasri:masterfrom pricop:Improve-file-saving-error-reporting
pricop wants to merge 1 commit intorashidlaasri:masterfrom
pricop:Improve-file-saving-error-reporting
Conversation
Rather than returning a string (which can differ, based on the selected language, let's return a boolean instead. We can then do the validation in the Controller based on the boolean value (true/false). In its current state, if the .env file can't be written, the user still gets redirected to the database controller. In the proposed form, we can potentially cancel the request, and return back with an error message, so the user doesn't lose his input values until the .env file permissions get updated. The entire process will work exactly the same as before, just provides more flexibility for those with custom changes to it.
mrahmadt
approved these changes
Jul 21, 2020
|
Great idea Thanks |
guifelix
reviewed
Mar 31, 2021
guifelix
reviewed
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than returning a string (which can differ, based on the selected language), let's return a boolean instead.
We can then do the validation in the Controller based on the boolean value (true/false).
In its current state, if the .env file can't be written, the user still gets redirected to the database controller.
In the proposed form, we can potentially cancel the request, and return back with an error message, so the user doesn't lose his input values until the .env file permissions get updated.
The entire process will work exactly the same as before, just provides more flexibility for those with custom changes to it.