Skip to content

Add board-header for CPB board#3093

Open
rallepalaveev wants to merge 5 commits into
raspberrypi:developfrom
rallepalaveev:master
Open

Add board-header for CPB board#3093
rallepalaveev wants to merge 5 commits into
raspberrypi:developfrom
rallepalaveev:master

Conversation

@rallepalaveev

@rallepalaveev rallepalaveev commented Jul 22, 2026

Copy link
Copy Markdown

Added CPB.h for CPB board

@lurch lurch changed the title Add files via upload Add board-header for CPB board Jul 22, 2026
@lurch

lurch commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Could you provide a web-link to more information about this board please, so that we can cross-check that this PR is correct?

@lurch lurch added this to the 2.4.0 milestone Jul 22, 2026
@rallepalaveev

rallepalaveev commented Jul 22, 2026

Copy link
Copy Markdown
Author

@lurch

lurch commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Would you be averse to naming this clintech_cpb.h ? (which is the convention that other 3rd-party boards tend to use, and also might make it easier for people to figure out what "CPB" is referring to 🙂 )
The https://clintech.net/CPB/CPB3.jpg photo shows that you're using RP2354B0A4 which I think means you could safely set PICO_RP2350_A2_SUPPORTED to 0 ?
Otherwise this LGTM.

@lurch lurch self-assigned this Jul 23, 2026
@rallepalaveev

Copy link
Copy Markdown
Author

Hi,

Thank you for the recommendations.

I have renamed the file to clintech_cpb.h
I have changed line 84: #define PICO_RP2350_A2_SUPPORTED 0

:)

Kind regards,

Ralle

Comment thread src/boards/include/boards/clintech_cpb.h Outdated
Comment thread src/boards/include/boards/clintech_cpb.h Outdated
Comment thread src/boards/include/boards/clintech_cpb.h Outdated
#define PICO_FLASH_SIZE_BYTES (2 * 1024 * 1024)
#endif

pico_board_cmake_set_default(PICO_RP2350_A2_SUPPORTED, 1)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be 0, to match the setting on line 84.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, many thanks for your comments, I have addressed them, I hope correctly.

Would you kindly review and let me know if OK now.

Then, as it seems like the pull request was rejected, do I need to request again?

Thank you.

Ralle.

@lurch

lurch commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Hello @rallepalaveev , you've just helped me uncover a bug in the check_board_header.py script 😂 It's rejecting board headers that set PICO_RP2350_A2_SUPPORTED to 0, which it shouldn't be doing!
I'll create a PR to fix that, and we'll need to get that PR merged before we can then merge your PR. (So in the meantime, please set PICO_RP2350_A2_SUPPORTED back to 0, don't worry about the failing CI, and then be patient while we fix the check_board_header.py script.)

@rallepalaveev

Copy link
Copy Markdown
Author

Hi, I am glad I could help by chance though! Reverted the values.

R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants