Conversation
The Hilao post-processing stage segfaults at process exit due to a static destruction order bug in libhailort. The VDevice singleton is held in a static unique_ptr which gets destroyed during exit() teardown, but by that point other statics inside libhailort that the VDevice destructor depends on have already been destroyed, causing a use-after-free crash in Buffer::~Buffer(). The fix is to intentionally leak the VDevice by storing it as a raw pointer instead of a unique_ptr. The OS reclaims the memory at process exit anyway, and this avoids triggering the buggy libhailort destructor. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hilao post-processing stage segfaults at process exit due to a static destruction order bug in libhailort. The VDevice singleton is held in a static unique_ptr which gets destroyed during exit() teardown, but by that point other statics inside libhailort that the VDevice destructor depends on have already been destroyed, causing a use-after-free crash in Buffer::~Buffer().
The fix is to intentionally leak the VDevice by storing it as a raw pointer instead of a unique_ptr. The OS reclaims the memory at process exit anyway, and this avoids triggering the buggy libhailort destructor.