Skip to content

Highlight missing translations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Highlight missing translations #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion views/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,37 @@
<th><?php echo html($lang); ?></th>
<?php endforeach ?>
</tr>
<?php $stats = array('missing translation' => 0, 'same translation' => 0); ?>

<?php foreach ($translations as $key => $strings): ?>
<tr>
<td style="font-style: italic; border-bottom: 1px solid grey"><?php echo esc($key); ?></td>

<?php
$keyStyle = "";
$values = array();
foreach ($languages as $lang) {
$values[$strings[$lang]] = 1;
}

if (count($values) == count($languages)) {
// each language is different
$keyStyle = "background-color: lightgreen;";
} else {
// at least two languages share the same translated value,
// which indicates missing translation

if (array_key_exists('', $values)) {
// a translation value is completely missing
$keyStyle = "background-color: firebrick;";
$stats['missing translation']++;
} else {
$keyStyle = "background-color: lightyellow;";
$stats['same translation']++;
}
}
?>

<td style="font-style: italic; border-bottom: 1px solid grey; <?php echo $keyStyle; ?>"><?php echo esc($key); ?></td>
<?php foreach ($languages as $lang): ?>
<?php $value = $strings[$lang]; $value = str_replace("\"", "&#34;", $value); ?>
<td><input style="width: 100%" type="text" name="<?php echo esc("trans__${lang}__${key}"); ?>" value="<?php echo $value ?>"></td>
Expand All @@ -30,6 +58,16 @@
<input class="btn btn-rounded btn-submit" type="submit" value="<?php echo l::get('save'); ?>">
</fieldset>
</form>

<h2 class="hgroup hgroup-single-line hgroup-compressed cf"><span class="hgroup-title">Statistics</span></h2>
<ul>
<li><span style="background-color: lightyellow">Keys with same translations: <?php echo $stats['same translation']; ?></span>
Two or more languages share the same translated value. This could be correct, but it could also mean, that the
translation was simply overlooked.
</li>
<li><span style="background-color: firebrick">Keys with missing translations: <?php echo $stats['missing translation']; ?></span>
</li>
</ul>
</div>
</div>

Expand Down