Use ratatui::run() for managing terminal lifecycle#142
Merged
joshka merged 6 commits intoratatui:mainfrom Jul 15, 2025
Merged
Conversation
Contributor
Author
|
It seems the formatting defaults for edition 2024 are slightly different than 2021, which is why all those extraneous changes are in there; they were done automatically. |
Member
|
Perhaps would you mind doing a quick PR for flipping to 2024 edition and then rebasing this change on that. I'll have to take a deeper look at this to understand the impact on the async changes. |
Contributor
Author
Done! See #143 . |
nebkor
commented
Jul 15, 2025
Member
|
Added a few small tweaks to the approach:
Does this look good to you? |
Contributor
Author
I love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the custom
tuimodule for setting up the terminal and panic handlers, and instead uses the newrun()function from Ratatui 0.30. Something to note is that I had to change themainfunc to be non-async, since therunfunction takes a sync closure, so I used the Tokio runtime'sblock_on()method inside it; I'd love to see a better way to do that.