Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure all components in base.yaml have an id #196

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

brgaulin
Copy link
Contributor

@brgaulin brgaulin commented Jan 23, 2024

fixes #106

Example usage of these ids:

packages:
  remote_package:
    url: https://github.com/ratgdo/esphome-ratgdo
    files: [base.yaml]
    refresh: 1s
button: 
  - id: !remove ${id_prefix}_safe_mode
  - id: !extend ${id_prefix}_restart
    internal: true

@brgaulin
Copy link
Contributor Author

The changes I made for api: seemed to cause issues. I removed those and was able to remove the service with the following:

api:
  services: !remove

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

It looks like https://github.com/ratgdo/esphome-ratgdo/blob/main/base_secplusv1.yaml needs the same change

@brgaulin
Copy link
Contributor Author

Good catch! Added in the base_secplusv1.yaml ids

@bdraco
Copy link
Member

bdraco commented Jan 30, 2024

Thanks @brgaulin

@bdraco bdraco merged commit 17a74f8 into ratgdo:main Jan 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ID's for customization
2 participants