Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping firmware filenames #208

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 26, 2024

The name of the firmware files were not unique enough for the builder as it uses the config name. To fix this I have forked the builder and made the following change: ratgdo/esphome-build-action@61acb0e

I also added the D1 mini (non lite) 8266 for the v2.5 board

fixes #209

The name of the firmware files were not unique enough
and since the builder use the generated name, we need
to add the trailers to prevent them from being overwritten

https://github.com/esphome/build-action/blob/main/entrypoint.py
The name of the firmware files were not unique enough
and since the builder use the generated name, we need
to add the trailers to prevent them from being overwritten

https://github.com/esphome/build-action/blob/main/entrypoint.py
The name of the firmware files were not unique enough
and since the builder use the generated name, we need
to add the trailers to prevent them from being overwritten

https://github.com/esphome/build-action/blob/main/entrypoint.py
@PaulWieland
Copy link
Contributor

reported in #209

@bdraco
Copy link
Member Author

bdraco commented Jan 26, 2024

changing the name is going to break mdns so we can't do that

@bdraco bdraco marked this pull request as ready for review January 26, 2024 23:22
@bdraco bdraco merged commit 2faa994 into main Jan 26, 2024
14 checks passed
@bdraco bdraco deleted the fix_binary_filename_conflict branch January 26, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESPHome install page pointing to incorrect firmware file?
2 participants