Fix overlapping firmware filenames #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the firmware files were not unique enough and since the builder use the generated name, we need to add the trailers to prevent them from being overwritten https://github.com/esphome/build-action/blob/main/entrypoint.py
The name of the firmware files were not unique enough and since the builder use the generated name, we need to add the trailers to prevent them from being overwritten https://github.com/esphome/build-action/blob/main/entrypoint.py
The name of the firmware files were not unique enough and since the builder use the generated name, we need to add the trailers to prevent them from being overwritten https://github.com/esphome/build-action/blob/main/entrypoint.py
|
reported in #209 |
|
changing the name is going to break mdns so we can't do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the firmware files were not unique enough for the builder as it uses the config name. To fix this I have forked the builder and made the following change: ratgdo/esphome-build-action@61acb0e
I also added the D1 mini (non lite) 8266 for the v2.5 board
fixes #209