Skip to content

Enhance OPEN state to report position#396

Draft
breakingspell wants to merge 2 commits intoratgdo:mainfrom
breakingspell:open-cover-position
Draft

Enhance OPEN state to report position#396
breakingspell wants to merge 2 commits intoratgdo:mainfrom
breakingspell:open-cover-position

Conversation

@breakingspell
Copy link
Contributor

@breakingspell breakingspell commented Apr 2, 2025 •
edited
Loading

This PR:

  • Sets the cover state to OPEN after STOP action at a target position
    • This closes the OPENING state loop present in the drycontact logic
    • Other protocols poll status from the opener and don't have that issue
      • This needs tested to confirm nothing has regressed on the other protocols
  • Reports back the cover position rather than 1.0 value in the OPEN state, visible in Home Assistant

image

Fixes:

Dependencies for Dry Contact firmware:

The other protocols shouldn't require additional changes, testing needs to ensure nothing is regressed. 🤠

TODO:

  • Timeout to OPEN state if door is manually stopped partially with wall button/remote (this currently does not time out and stays OPENING|CLOSING)
  • Review the value returned once door stopped, perhaps "round up" to return the target value instead, assuming the door is correctly calibrated+positioned.

@breakingspell breakingspell mentioned this pull request Apr 2, 2025
Merged
breakingspell
breakingspell commented Apr 3, 2025
View reviewed changes
@breakingspell
Copy link
Contributor Author

breakingspell commented Apr 7, 2025

Not sure if the latest commit encroaches on other protocols, but I moved the OPEN position override to the STOP/TOGGLE action handler.

@breakingspell
Copy link
Contributor Author

breakingspell commented Apr 11, 2025 •
edited
Loading

This has been working very well for a few weeks, with two outstanding issues:

  • The percentage returned is sometimes behind the door state

    • Requesting 15% can return 15, 14, 12, 10, etc. The door is actually open in the proper position but the counter is rounded down.
    • Rounding the output to multiples of 5/10% may present better and correct for this, but masks the actual returned position. This may also require modifying the cover/position calculations, unnecessarily.

  • (Dry-contact-specific) Bypassing ratgdo and using the wall button or RF remote to stop the door partially will replicate the original issue.

    • The Opening status and counter are triggered by the Closed limit sensor turning off, not by the wall button/remote. The other sensor is not encountered, so the status stays in Opening and counts up to 97%. Same with Closing inversely.
    • Haven't dug in yet, but not sure if this can be accounted for without substantial work regarding dry contact wall buttons, if it's physically possible for ratgdo to monitor button presses. The remotes/paired cars operate entirely within the GDO controller and would be inaccessible to ratgdo..
      • If not, this could be accounted for with a timeout to the unknown position state, using a 50% best guess to indicate the door was last stopped manually and could be in any position.
      • ratgdo's next operation would need to be Toggle in order to encounter a sensor and reorient.

Edit: brainstorm on the second issue, we could potentially handle the Opening/Closing state timeout based on if it were invoked by external sensor change (limit switch), versus a firmware button/function call. Probably a lot simpler than I had initially thought. This could also be handled in a separate merge.

@breakingspell breakingspell mentioned this pull request May 11, 2025
Open
@breakingspell breakingspell force-pushed the open-cover-position branch 2 times, most recently from 8a3423a to 54f8cf5 Compare July 15, 2025 05:37
@azilberbaum
Copy link

azilberbaum commented Aug 5, 2025

Edit: brainstorm on the second issue, we could potentially handle the Opening/Closing state timeout based on if it were invoked by external sensor change (limit switch), versus a firmware button/function call. Probably a lot simpler than I had initially thought. This could also be handled in a separate merge.

I think this is a good approach, if ever the limit sensors see the door is open or closed it should update the position.

@breakingspell
Copy link
Contributor Author

breakingspell commented Aug 6, 2025 •
edited
Loading

Edit: brainstorm on the second issue, we could potentially handle the Opening/Closing state timeout based on if it were invoked by external sensor change (limit switch), versus a firmware button/function call. Probably a lot simpler than I had initially thought. This could also be handled in a separate merge.

I think this is a good approach, if ever the limit sensors see the door is open or closed it should update the position.

Yes, subscribing to the Limit Switch's states and handling the external state change as an OPEN/CLOSE would resolve this.
As it is, that issue is the only one I encounter in day-to-day, housemates use the GDO wall button to partially open instead of scene switch in other room, so the usual position reporting is not handled.

@breakingspell
Set door state to OPEN after position STOP
ce7c061 
Use position float instead of 1.0 for open state
sjafferali added a commit to sjafferali/esphome-ratgdo that referenced this pull request Feb 10, 2026
@sjafferali
fix: use timeout-based direction reversal for dry contact
6a7fc86 
For dry contact openers, replace the callback-based stop-then-reverse
pattern with a timeout-based approach. Sends STOP, waits 1 second for
the pulse to complete and the gate to settle, then re-calls door_open
or door_close.

This fixes two problems with the original approach:
1. The on_door_state callback waits for STOPPED but PR ratgdo#396 sets OPEN,
   so the follow-up command was never sent.
2. Even if the callback matched, the follow-up tx_pin pulse would
   overlap with the still-active STOP pulse (both HIGH within the
   same 500ms window), resulting in one physical button press instead
   of two.

Also adds stop-first handling to door_open() for dry contact when the
gate is currently CLOSING, which was previously missing entirely.
sjafferali added a commit to sjafferali/esphome-ratgdo that referenced this pull request Feb 10, 2026
@sjafferali
fix: use timeout-based direction reversal for dry contact
df736b2 
For dry contact openers, replace the callback-based stop-then-reverse
pattern with a timeout-based approach. Sends STOP, waits 1 second for
the pulse to complete and the gate to settle, then re-calls door_open
or door_close.

This fixes two problems with the original approach:
1. The on_door_state callback waits for STOPPED but PR ratgdo#396 sets OPEN,
   so the follow-up command was never sent.
2. Even if the callback matched, the follow-up tx_pin pulse would
   overlap with the still-active STOP pulse (both HIGH within the
   same 500ms window), resulting in one physical button press instead
   of two.

Also adds stop-first handling to door_open() for dry contact when the
gate is currently CLOSING, which was previously missing entirely.

Both functions cancel any pending reverse timeout on entry to prevent
stale timeouts from interfering with rapid command changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@breakingspell @azilberbaum

Comments