Skip to content

Dry Contact Obstruction sensor improvements #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breakingspell wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Dry Contact Obstruction sensor improvements #401

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76d87f9
If obstruction sensor is triggered during CLOSING, set door state to
breakingspell Apr 5, 2025
6dbfe48
Consider rebounded Open state in door_query_state timeout
breakingspell Apr 7, 2025
5f431f0
Isolate obstruction fixes to dry contact protocol
breakingspell Sep 17, 2025
afb43eb
Isolate close logic for PROTOCOL_SECPLUSV2
breakingspell Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions components/ratgdo/ratgdo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,13 @@ namespace ratgdo {
// if the line is high and was last asleep more than 700ms ago, then there is an obstruction present
if (current_millis - last_asleep > 700) {
this->obstruction_state = ObstructionState::OBSTRUCTED;
#ifdef PROTOCOL_DRYCONTACT
if (*this->door_state == DoorState::CLOSING) {
this->received(DoorState::OPENING);
// If obstruction sensor is tripped during closing,
// assume the motor has reversed direction.
}
#endif
}
}
}
Expand Down Expand Up @@ -644,13 +651,23 @@ namespace ratgdo {
return;
}

#ifdef PROTOCOL_SECPLUSV2
// Most ROW Sec+ 2 openers don't actually have obstruction sensors,
// they ignore the discrete close command, but accept a toggle command.
if (this->flags_.obstruction_sensor_detected) {
this->door_action(DoorAction::CLOSE);
} else if (*this->door_state == DoorState::OPEN) {
ESP_LOGD(TAG, "No obstruction sensors detected. Close using TOGGLE.");
this->door_action(DoorAction::TOGGLE);
}
#else
this->door_action(DoorAction::CLOSE);
#endif

#ifdef PROTOCOL_DRYCONTACT
// Dry Contact protocol can't query state from GDO
// The protocol sets state via limit switch
#else
if (*this->closing_duration > 0) {
// query state in case we don't get a status message
set_timeout("door_query_state", (*this->closing_duration + 2) * 1000, [this]() {
Expand All @@ -660,6 +677,7 @@ namespace ratgdo {
}
});
}
#endif
}

void RATGDOComponent::door_stop()
Expand Down