Skip to content

Fix secplus1 emulation noise issue #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveEasley wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −3
Open

Fix secplus1 emulation noise issue #548

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3772a2
Fix secplus1 emulation noise issue
SteveEasley Feb 17, 2026
4ef6054
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 17, 2026
6787af4
Ensure bad packets cant corrupt state
SteveEasley Feb 17, 2026
70a1224
Ensure bad packets cant corrupt state v2
SteveEasley Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/ratgdo/secplus1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ namespace ratgdo {
{
this->wall_panel_emulation_state_ = WallPanelEmulationState::WAITING;
this->wall_panel_emulation_start_ = millis();
this->flags_.wall_panel_starting = false;
this->door_state = DoorState::UNKNOWN;
this->light_state = LightState::UNKNOWN;
this->scheduler_->cancel_timeout(this->ratgdo_, "wall_panel_emulation");
Expand Down Expand Up @@ -312,10 +313,12 @@ namespace ratgdo {

void Secplus1::handle_command(const RxCommand& cmd)
{
if (cmd.req == CommandType::TOGGLE_DOOR_RELEASE || cmd.resp == 0x31) {
if (this->wall_panel_emulation_state_ == WallPanelEmulationState::WAITING && (cmd.req == CommandType::TOGGLE_DOOR_RELEASE || cmd.resp == 0x31)) {
ESP_LOGD(TAG, "wall panel is starting");
this->flags_.wall_panel_starting = true;
} else if (cmd.req == CommandType::QUERY_DOOR_STATUS) {
}

if (cmd.req == CommandType::QUERY_DOOR_STATUS) {

DoorState door_state;
auto val = cmd.resp & 0x7;
Expand Down