Merged
Conversation
…an test threshold
* start adding joint polarisation products * compute natural grad with jax in hci * attempt to limit number of jax cpu threads per process * don't limit XLA cpu device count * use first element of tuple produced by cg in hci * tweaks * get grid app working with joint pol products. Add beams table to fits hdu * try IFT pol model with approx likelihood * convolving correlations is hard * polfusion * fiddle with BEAMS subtable * add some checks * Fix BEAMS subtable so that beam displays correctly in CARTA * small tweaks to parser * fix failing tests * use 90-PA in add_beampars * reinstate nearsest neighbour gridding for weighting tests * Also test FS in test_polproducts * fix flag ncorr for averaging routines, update Dockerfile, remove spotless cab * cache MFS PSFPARS in dds, make psfpars_mfs optional in dds2fits * simple transient injection in hci worker (no pol parameters) * update restore worker to work with multiple times and correlations * fix typos in restore worker, remove some unused imports * add complex convolve test when gridding correlations directly * render wsclean models to mds * remove product from fits name in model2comps * typo * fix axis order in model2comps, write out cube as sanity check * fix field delection in degrid worker * do not drop ncorr on flag before weight_data in hci * add inject-transients to hci config * pass mask into counts to weigts in hci * start adding polclean functionality. Don't double normalise restored image by wsum * add fskclean test --------- Co-authored-by: Landman Bester <lbester@com08.science.kat.ac.za>
… weights. tidy up and add min_padding parameter to hci worker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hciworker forbreifast