Skip to content

Allow disabling close action after sucessfull update #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flobz
Copy link

@flobz flobz commented Mar 7, 2024

In order to wait for reboot to mark update as succeeded I added an option to disable reporting update as finished successfully.

Thanks to that we can use an other program (and maybe one day rauc-hawkbit-updater) at boot to report update result.

Here is a chart to explain how the external program works:
image

sync_version_with_hawkbit: send booted version to hawkbit eclipse-hawkbit/hawkbit#1620

is_hawkbit_update_in_progress: rauc install a version but the box didn't mark the update as a success or a failure yet thanks to this PR

Related issue:

Reports Success Before Being Verified via Reboot #161

@flobz flobz force-pushed the feature/disable_close_action_stable branch from b1b2be2 to c3703fc Compare March 7, 2024 11:13
@Bastian-Krause
Copy link
Member

Can you elaborate on how the external program determines the appropriate action ID to send update feedback to?

@flobz
Copy link
Author

flobz commented Mar 18, 2024

Yes, the external program request https://eclipse.dev/hawkbit/rest-api/ddi.html#tag/DDI-Root-Controller/operation/getControllerBase and if there the response contains ["_links"]["deploymentBase"]["href"] then request this link to get the deployment version and the action id to send update feedback to.
I updated the desciprition of the PR to add a chart.

@Bastian-Krause Bastian-Krause added the enhancement New feature or request label Mar 13, 2025
@Bastian-Krause
Copy link
Member

Sorry for the long delay.

I am okay with the feature. @ejoerns needs to decide whether it's okay to have this as a stop gap solution until we have rauc/rauc#1114 + integration in rauc-hawkbit-updater.

I think the feature only makes sense with the information provided in this PR. So we need to add that in text form to the documentation. Otherwise it might cause more harm than benefit.

After a reboot, rauc-hawkbit-updater must only be started after the external program has terminated successfully to prevent another installation of the same artifact. This needs to be documented.

I'd suggest to wait with feedback integration until @ejoerns commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants