Skip to content

hawkbit-client: do not resume downloads for persistent server errors #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bastian-Krause wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hawkbit-client: do not resume downloads for persistent server errors #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/hawkbit-client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,9 +971,16 @@ static gpointer download_thread(gpointer data)
resume_from, &sha1sum, &speed, &error))
break;

// resume download under certain conditions
for (const gint *code = &resumable_codes[0]; *code; code++)
resumable |= g_error_matches(error, RHU_HAWKBIT_CLIENT_CURL_ERROR, *code);

// but do not resume download on persistent HTTP server errors
if (error->domain == RHU_HAWKBIT_CLIENT_HTTP_ERROR &&
error->code >= 400 && error->code < 500 &&
error->code != 408 && error->code != 429)
resumable = FALSE;

if (!hawkbit_config->resume_downloads || !resumable) {
g_prefix_error(&error, "Download failed: ");
goto report_err;
Expand Down
Loading