hawkbit-client: add strptime() error check#220
Open
Bastian-Krause wants to merge 1 commit into
Open
Conversation
Check for strptime() parsing failures, issue a warning and return the default config `retry_wait` value. We should not run into such issues since the value is hawkBit-controlled, but better be safe than sorry. While at it, initialize the tm struct, so reading unfilled fields does not lead to undefined behavior. This is for good measure only since %T fills all fields currently used. Signed-off-by: Bastian Krause <bst@pengutronix.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for strptime() parsing failures, issue a warning and return the default config
retry_waitvalue. We should not run into such issues since the value is hawkBit-controlled, but better be safe than sorry.While at it, initialize the tm struct, so reading unfilled fields does not lead to undefined behavior. This is for good measure only since %T fills all fields currently used.