Conversation
Added `strict` flag to RcnStatOptions struct. Added `rcnCountLogicalLinesStrict()` API function to reflect the old behaviour. The already existing `rcnCountLogicalLines()` API function changes the behaviour to be lenient. Since the exact counting behaviour is not part of the API contract, as documented, the change in behaviour is not a breaking change. Introduced `--strict` option in `scount` for strict syntax checking. Updated relevant functions to handle strict mode, causing immediate failure on syntax errors. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
…handling. Moved strict flag from evaluateSourceTree() function parameter to NodeEvalTrace struct. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Added check for empty soruce code input which fails when in strict mode but returns with success and zero count result when in lenient mode. Adjusted unit tests. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
strictflag to theRcnStatOptionsstruct.Adds the
rcnCountLogicalLinesStrict()API function to reflect the old behaviour. The already existingrcnCountLogicalLines()API function changes the behaviour to be lenient. Since the exact counting behaviour is not part of the API contract, as documented, the change in behaviour is not a breaking change.Introduces the
--strictoption inscountfor strict syntax checking.Updates relevant functions to handle strict mode, causing immediate failure on syntax errors.