fix: conditionally display media details - [CU-869bgh5j7] #214
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stub `useAccountSetup` in home layout tests.
Abdallah-farag27
requested review from
AhmedSobhy01,
AmrSamy59,
LoayAhmed304 and
im-saif
as code owners
Collaborator
|
Task linked: CU-869bgh5j7 fix media view responsiveness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a few targeted improvements to both the UI and the test suite. The main changes involve hiding a sidebar on smaller screens for better responsiveness and enhancing the test setup for the home layout.
UI Responsiveness:
TweetViewcomponent inapp/pages/media/[id].vueis now hidden on small and medium screens and only shown on large screens and above, improving the layout for mobile users. (app/pages/media/[id].vueL261-R261)Test Suite Enhancements:
test/nuxt/layouts/home.spec.tsfile now stubs theuseAccountSetupcomposable globally, ensuring tests can safely reference it without side effects.AccountSetupcomponent is stubbed astruein the test's component overrides, simplifying test rendering and avoiding unnecessary component logic.