-
Notifications
You must be signed in to change notification settings - Fork 1
RavenDB-24939: introduce healthcheck module #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewers please notice CI is currently red bc of broken py client: |
delegate_to: localhost | ||
ravendb.ravendb.healthcheck: | ||
url: "http://{{ ansible_hostname }}:8080" | ||
checks: ['node_alive', 'cluster_connectivity', 'node_databases_online'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
node_databases_online
gate automatically excludes the current node by resolving its tag from topology.
the node that we would need to exclude is actually the next one that we're about to update, not the current node...
But actually since you're doing node_database_online pre upgrade as well, then e.g. before putting C down, we're checking whether A and B has dbs online! Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @hiddenshadow21 that's something we could think about in regards to our healtchecks, to do that dbs check before - could spare us a couple of if
statements
- name: Sabotage B tcp connectivity | ||
hosts: ubuntu-bionic-node-b | ||
become: true | ||
gather_facts: no | ||
tasks: | ||
- name: Ensure iptables present | ||
become: true | ||
apt: | ||
name: iptables | ||
state: present | ||
update_cache: yes | ||
|
||
- name: Reject outbound cluster traffic | ||
ansible.builtin.command: iptables -I INPUT -p tcp --dport 38888 -j REJECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool testing
https://issues.hibernatingrhinos.com/issue/RavenDB-24939/Ansible-add-health-checks-when-version-upgrades-are-being-done
Test matrix: