Skip to content

Add option for download update file name. #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option for download update file name. #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AutoUpdater.NET/DownloadUpdateDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent
}
}

string fileName = string.IsNullOrEmpty(contentDisposition?.FileName)
string fileName = !string.IsNullOrEmpty(_args.DownloadFileName)
? _args.DownloadFileName:
string.IsNullOrEmpty(contentDisposition?.FileName)
? Path.GetFileName(_webClient.ResponseUri.LocalPath)
: contentDisposition.FileName;

Expand Down
6 changes: 6 additions & 0 deletions AutoUpdater.NET/UpdateInfoEventArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ public UpdateInfoEventArgs()
Mandatory = new Mandatory();
}

/// <summary>
/// It will be prioritized if provided. Used in cases where the download URL does not contain a file name (e.g., Base64) or the header does not include Content-Disposition
/// </summary>
[XmlElement("filename")]
public string DownloadFileName { get; set; }

/// <summary>
/// If new update is available then returns true otherwise false.
/// </summary>
Expand Down