Make background.js Node-safe and add test for default blocks editor mode#1
Open
Make background.js Node-safe and add test for default blocks editor mode#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
background.jsto be loaded in a Node test environment by avoiding runtime errors when Chrome APIs are absent.buildSystemPromptbehavior is covered wheneditorModeis omitted so the system defaults to Blocks guidance.node --test.Description
hasChromeRuntimecheck and wrap Chrome-specific listeners sobackground.jsis safe outside Chrome.buildSystemPromptfrombackground.jsusingmodule.exportsfor use in Node tests.package.jsonwith atestscript (node --test) and updatetests/background.test.jsto include a new test that verifies default Blocks guidance wheneditorModeis omitted.Testing
npm testwhich invokesnode --test.4tests passed and0failed.Codex Task