TODOs in storage/iceberg/impl.py in create_table_version #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolving the following TODOs in create_table_vesrion:
# TODO: ensure catalog.create_table() is idempotent
# TODO: get table and commit new metadata if table already exists?
Rationale
Simple changes to get onboarded onto the project.
Changes
Addressed catalog.create_table() idempotecy --> attempts to load existing iceberg table; if it doesn't exist it performs catalog.create_table()
Addressed new metadata commit to existing table --> if table exists, uses the iceberg table transaction and sets the properties to the table_properties.
Impact
n/a
Testing
Passes all current tests. Need guidance on how/where to add tests.
Regression Risk
n/a
Checklist
Unit tests covering the changes have been added
E2E testing has been performed
Additional Notes
Any additional information or context relevant to this PR.