TODOs in storage/iceberg/impl.py in create_table_version

[sahil-03]

Summary

Resolving the following TODOs in create_table_vesrion:
# TODO: ensure catalog.create_table() is idempotent
# TODO: get table and commit new metadata if table already exists?

Rationale

Simple changes to get onboarded onto the project.

Changes

Addressed catalog.create_table() idempotecy --> attempts to load existing iceberg table; if it doesn't exist it performs catalog.create_table()

Addressed new metadata commit to existing table --> if table exists, uses the iceberg table transaction and sets the properties to the table_properties.

Impact

n/a

Testing

Passes all current tests. Need guidance on how/where to add tests.

Regression Risk

n/a

Checklist

• Unit tests covering the changes have been added

  • If this is a bugfix, regression tests have been added

• E2E testing has been performed

Additional Notes

Any additional information or context relevant to this PR.

[pdames]

LGTM! Feel free to delete the TODO statements on line 396 and 397 (and remove the corresponding comments about resolve todo #n), and then I'll get this merged.

[pdames]

Hey @sahil-03 - looks like we've got a linter failure in the CI/CD workflow - can you run make lint in your workspace and check in another revision with all linter checks passing? Most issues will be auto-resolved, but the linter will stop to let you review its changes after every failure, so you may need to run it a few times to resolve all issues.