fix: update multiple_namespaces_role.yaml to match role.yaml#28
Open
shaoqin2 wants to merge 1 commit intoray-project:mainfrom
Open
fix: update multiple_namespaces_role.yaml to match role.yaml#28shaoqin2 wants to merge 1 commit intoray-project:mainfrom
shaoqin2 wants to merge 1 commit intoray-project:mainfrom
Conversation
shaoqin2
force-pushed
the
shlu/addbatchjobs
branch
from
5091e06 to
990b57b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #26
I also noticed RBAC for
route.openshift.iois missing from the multiple_namespaces_role, added that as well. Diffed the rule section of the two yaml and now they are consistent.