feat: add support for watchNamespace in kuberay-apiserver#29
Open
shaoqin2 wants to merge 1 commit intoray-project:mainfrom
Open
feat: add support for watchNamespace in kuberay-apiserver#29shaoqin2 wants to merge 1 commit intoray-project:mainfrom
shaoqin2 wants to merge 1 commit intoray-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #27
Add the support for kuberay-apiserver to also install role/rolebinding in a list of namespaces like kuberay-operator. Did it slightly differently from kuberay-operator so the rules section of the RBAC is shared instead of repeated to reduce the possible drift between the two files
I verified that this change does not change helm output for existing usecase
Applied this patch
And finally test the multi namespace feature work