[kubectl-plugin] Add kubectl ray create cluster by chiayi · Pull Request #2607 · ray-project/kuberay

chiayi · 2024-12-04T21:53:33Z

Why are these changes needed?

Adds kubectl ray create cluster command.

Related issue number

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

chiayi · 2024-12-04T23:26:46Z

Going to post Screenshot of manual test soon.

kubectl-plugin/pkg/cmd/create/create_cluster.go

andrewsykim · 2024-12-05T02:29:01Z

kubectl-plugin/pkg/cmd/create/create_cluster.go

+		kubectl ray create cluster -f raycluster-stample.yaml
+
+		# Creates Ray Cluster from flags input
+		kubectl ray create cluster sample-cluster --ray-version 2.9.0 --image rayproject/ray:2.9.0 --head-cpu 1 head-memory 5Gi --worker-grp-name worker-group1 --worker-replicas 3 --worker-cpu 1 --worker-memory 5Gi


Should we add a --dry-run or -o yaml option to print the generated YAML from this command?

Ah, I see from the implementation that we're already printing the generated YAML

would having --dry-run be a better option than just printing out the yaml and waiting for user input?

would having --dry-run be a better option than just printing out the yaml and waiting for user input?

Yeah maybe -- by default the output should just be "Created Ray cluster ...." and --dry-run can output the YAML? Not sure we need to print the YAML every time

I've added a --dry-run flag that will print out the yaml if its set and will just apply the yaml if unset.

kubectl-plugin/pkg/cmd/create/create_cluster.go

chiayi · 2024-12-06T00:31:51Z

Screenshot of run:

kubectl-plugin/pkg/cmd/create/create_cluster.go

kubectl-plugin/pkg/util/generation/generation.go

kubectl-plugin/pkg/cmd/create/create_cluster.go

MortalHappiness

BTW, we can try using RayClusterApplyConfiguration if importing that package doesn't result in a dependency conflict. It might be simpler than the current implementation of generating YAML files.

kubectl-plugin/pkg/cmd/create/create_cluster.go

kubectl-plugin/pkg/util/generation/generation_test.go

chiayi · 2024-12-10T04:24:04Z

BTW, we can try using RayClusterApplyConfiguration if importing that package doesn't result in a dependency conflict. It might be simpler than the current implementation of generating YAML files.

@MortalHappiness @andrewsykim I was able to use RayClusterApplyConfiguration instead of manually creating the RayCluster object, converting to a map, and then removing unnecessary fields. But I had do a workaround for rayStartParams since the applyconfigurations wouldn't accept an empty string map by using default values for dashboard-host and metrics-export-port for headGroupSpec and workerGroupSpecs respectively. PTAL! Thank you!

kubectl-plugin/pkg/util/generation/generation.go

kubectl-plugin/pkg/cmd/create/create_cluster.go

kubectl-plugin/pkg/util/generation/generation.go

kubectl-plugin/pkg/cmd/create/create_cluster.go

andrewsykim · 2024-12-11T15:28:33Z

@MortalHappiness can you do another review?

chiayi mentioned this pull request Dec 4, 2024

[Umbrella] Kubectl-plugin to Beta #2608

Closed

14 tasks

andrewsykim reviewed Dec 5, 2024

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Outdated Show resolved Hide resolved

kevin85421 assigned andrewsykim and MortalHappiness Dec 5, 2024

chiayi force-pushed the kubectl-plugin-create branch 3 times, most recently from 3a13d4b to 7cd01b2 Compare December 6, 2024 00:11

chiayi force-pushed the kubectl-plugin-create branch from 7cd01b2 to 8b9e893 Compare December 6, 2024 00:33

This comment was marked as duplicate.

Sign in to view

andrewsykim reviewed Dec 6, 2024

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Show resolved Hide resolved

kubectl-plugin/pkg/util/generation/generation.go Outdated Show resolved Hide resolved

andrewsykim reviewed Dec 6, 2024

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Outdated Show resolved Hide resolved

MortalHappiness reviewed Dec 6, 2024

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Outdated Show resolved Hide resolved

chiayi force-pushed the kubectl-plugin-create branch 3 times, most recently from 006150a to 0a4815a Compare December 10, 2024 04:12

andrewsykim reviewed Dec 10, 2024

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Outdated Show resolved Hide resolved

kubectl-plugin/pkg/util/generation/generation_test.go Outdated Show resolved Hide resolved

chiayi force-pushed the kubectl-plugin-create branch 2 times, most recently from 2d73a55 to 274c03d Compare December 10, 2024 04:20

chiayi force-pushed the kubectl-plugin-create branch from 274c03d to 7bec5a9 Compare December 10, 2024 04:24

chiayi requested review from MortalHappiness and andrewsykim December 10, 2024 17:00

MortalHappiness requested changes Dec 10, 2024

View reviewed changes

chiayi force-pushed the kubectl-plugin-create branch from 7bec5a9 to 557252d Compare December 10, 2024 17:16

andrewsykim reviewed Dec 10, 2024

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Outdated Show resolved Hide resolved

kubectl-plugin/pkg/util/generation/generation.go Show resolved Hide resolved

andrewsykim reviewed Dec 10, 2024

View reviewed changes

chiayi force-pushed the kubectl-plugin-create branch from 557252d to 54a77e2 Compare December 10, 2024 18:56

chiayi force-pushed the kubectl-plugin-create branch from 54a77e2 to 7e1032e Compare December 10, 2024 21:33

chiayi requested review from MortalHappiness and andrewsykim December 10, 2024 23:24

andrewsykim approved these changes Dec 10, 2024

View reviewed changes

andrewsykim enabled auto-merge (squash) December 10, 2024 23:48

Add kubectl ray create cluster

7f8e8a0

auto-merge was automatically disabled December 10, 2024 23:55
Head branch was pushed to by a user without write access

chiayi force-pushed the kubectl-plugin-create branch from 7e1032e to 7f8e8a0 Compare December 10, 2024 23:55

andrewsykim enabled auto-merge (squash) December 11, 2024 15:00

MortalHappiness approved these changes Dec 11, 2024

View reviewed changes

andrewsykim merged commit 12babc8 into ray-project:master Dec 11, 2024
19 checks passed

Ygnas pushed a commit to Ygnas/kuberay that referenced this pull request Mar 20, 2025

Add kubectl ray create cluster (ray-project#2607)

7a87ddb

Conversation

chiayi commented Dec 4, 2024

Why are these changes needed?

Related issue number

Checks

Uh oh!

chiayi commented Dec 4, 2024

Uh oh!

Uh oh!

andrewsykim Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

andrewsykim Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

chiayi Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

andrewsykim Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

chiayi Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chiayi commented Dec 6, 2024

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MortalHappiness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chiayi commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewsykim commented Dec 11, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chiayi commented Dec 10, 2024 •

edited

Loading