[Feature] Dependabot send out issue if package upgrade failure by CheyuWu · Pull Request #3512 · ray-project/kuberay

CheyuWu · 2025-04-29T17:33:18Z

Why are these changes needed?

Currently, failed upgrades require manual checking by maintainers. This change aims to improve the process by:

Automatically assigning the repo maintainer if the upgrade succeeds
Automatically creates an issue if the upgrade fails

Manual Testing

I have removed the condition specific to Dependabot, because I cannot trigger Dependabot manually

Verified the pipeline with a successful case → auto-assigns all maintainers

Verified the pipeline with a failure case → auto-creates an issue

If Dependabot fails in the pipeline

The new issue will look like

Verified the pipeline with a failure case that includes `reCommit` → does not auto-create an issue

After the dependabot reopened the issue or re-committed the issue and the pipeline failure, it won't reCreate an issue

Related issue number

Closes #3484

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

CheyuWu · 2025-04-29T17:37:40Z

.github/workflows/dependabot-notifier.yaml

+
+jobs:
+  monitor-dependabot:
+    if: github.actor == 'dependabot[bot]'


I'm not sure how to trigger Dependabot. During manual testing, this condition was not set.

CheyuWu · 2025-04-29T17:38:54Z

.github/workflows/dependabot-notifier.yaml

+    if: github.actor == 'dependabot[bot]'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Wait for checks to complete


This will make sure all of the pipeline is finished before running this script

CheyuWu · 2025-04-29T17:39:42Z

.github/workflows/dependabot-notifier.yaml

+              console.log("All checks passed.");
+            }
+      - name: Create issue on failure
+        if: failure() && github.event.action == 'opened'


This is to ensure the bot won't spam the issue.

CheyuWu · 2025-04-29T17:40:34Z

.github/workflows/dependabot-notifier.yaml

+            const maintainers = collaborators
+              .filter(user => user.permissions.admin)
+              .map(user => user.login);
+
+            // Step 3: Assign to the PR
+            if (maintainers.length > 0) {
+              await github.rest.issues.addAssignees({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.issue.number,
+                assignees: maintainers,
+              });


This will assign all of the maintainers

curious as of now, who will be assigned?

user.permissions.admin =>["ericl","pcmoritz","richardliaw","Jeffwan","zhe-thoughts"]`

Well, I should assign the reviewer directly, not via the API.

I also try user.permissions.pusher and user.permission.maintainer.
The result is

Pusher: [ 'ericl', 'pcmoritz', 'caitengwei', 'wilsonwang371', 'richardliaw', 'Jeffwan', 'zhe-thoughts', 'andrewsykim', 'akanso', 'simon-mo', 'DmitriGekhtman', 'sriram-anyscale' ] Maintainers: [ 'ericl', 'pcmoritz', 'caitengwei', 'richardliaw', 'Jeffwan', 'zhe-thoughts', 'akanso', 'simon-mo', 'DmitriGekhtman' ]

https://github.com/ray-project/kuberay/actions/runs/14836955695/job/41650311396?pr=3544

CheyuWu · 2025-04-29T17:43:32Z

Hi @dentiny, PTAL

By the way, if testing is still being considered, Dependabot will be needed. Please let me know, and I’ll find a way to test it properly.

dentiny · 2025-04-30T18:36:16Z

Sorry for the delay, I will take a look later today; feel free to ping me directly on slack if I don't get back to you. Thank you!

dentiny

Could you please link the PR and pipeline in the PR description? Thank you!

dentiny · 2025-05-01T02:38:48Z

.github/workflows/dependabot-notifier.yaml

+            await github.rest.issues.create({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              title: `Dependabot upgrade failed: #${context.issue.number}`,


nit: include the PR titled in github issue? I think there're pretty well formatted.

dentiny · 2025-05-01T02:39:54Z

.github/workflows/dependabot-notifier.yaml

+        with:
+          script: |
+            // Step 1: Get collaborators
+            const collaborators = await github.paginate(


Q: do we issue one request or multiple requests, if the overall collaborator numbers are >100?

Yes, it will automatically issue multiple requests if there are more than 100 collaborators.

dentiny · 2025-05-01T02:41:15Z

.github/workflows/dependabot-notifier.yaml

+                assignees: maintainers,
+              });
+            } else {
+              console.log("No maintainers found to assign.");


console.warn

CheyuWu · 2025-05-05T12:05:38Z

.github/workflows/dependabot-notifier.yaml

+
+jobs:
+  monitor-dependabot:
+    if: github.event.pull_request.user.login == 'dependabot[bot]'


I changed github.actor to github.event.pull_request.user.login
Reference

CheyuWu · 2025-05-05T17:03:13Z

.github/workflows/dependabot-notifier.yaml

+        uses: actions/github-script@v7
+        with:
+          script: |
+            const maintainers = ["dentiny"];


According to #3512 (comment), we should use fixed maintainer name

If there are any other users that I should add, please let me know

CheyuWu · 2025-05-05T17:05:46Z

.github/workflows/dependabot-notifier.yaml

+            await github.rest.issues.create({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              title: `Dependabot upgrade failed: #${context.issue.number} - ${context.payload.pull_request.title}`,


I have added the pr title

CheyuWu · 2025-05-05T19:15:00Z

Hi @dentiny, I have updated the code

Change the issue title
Use fixed maintainers instead, because [Feature] Dependabot send out issue if package upgrade failure #3512 (comment)
I changed github.actor to github.event.pull_request.user.login
Reference

And I have run the pipeline in my repo

failure pr
Test/bot/notifier/fail CheyuWu/kuberay#28
The issue created from the failure pr
Dependabot upgrade failed: #28 - Test/bot/notifier/fail CheyuWu/kuberay#29
success pr
Test/bot/notifier/success CheyuWu/kuberay#26

PTAL

CheyuWu commented Apr 29, 2025

View reviewed changes

CheyuWu changed the title ~~[WIP][Feature] Dependabot send out issue if package upgrade failure~~ [Feature] Dependabot send out issue if package upgrade failure Apr 29, 2025

dentiny reviewed May 1, 2025

View reviewed changes

CheyuWu force-pushed the bot/notifier branch 2 times, most recently from 0deb46a to e4ab607 Compare May 5, 2025 11:41

CheyuWu added 2 commits May 5, 2025 19:41

[Feature] Dependabot send out issue if package upgrade failure

e4ab607

fix: use pr owner to ensure the pr is opened by dependabot

f03d7f3

CheyuWu commented May 5, 2025

View reviewed changes

CheyuWu force-pushed the bot/notifier branch 2 times, most recently from 0d4abd3 to 42d8419 Compare May 5, 2025 18:12

CheyuWu added 2 commits May 6, 2025 02:12

chore: add full maintainer list

42d8419

fix: add permission to write issue and pr

b30ff5b

Conversation

CheyuWu commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Manual Testing

Verified the pipeline with a successful case → auto-assigns all maintainers

Verified the pipeline with a failure case → auto-creates an issue

Verified the pipeline with a failure case that includes reCommit → does not auto-create an issue

Related issue number

Checks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheyuWu May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheyuWu commented Apr 29, 2025

Uh oh!

dentiny commented Apr 30, 2025

Uh oh!

dentiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheyuWu commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CheyuWu commented Apr 29, 2025 •

edited

Loading

Verified the pipeline with a failure case that includes `reCommit` → does not auto-create an issue

CheyuWu May 5, 2025 •

edited

Loading

CheyuWu commented May 5, 2025 •

edited

Loading