Clean up unused label for volcano scheduler #4305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wei-chenglai <[email protected]>
seanlaii
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
Contributor
Author
|
Hi @Future-Outlier @rueian @win5923 , please take a look when you have a chance. Thanks! |
win5923
approved these changes
Dec 23, 2025
Collaborator
There was a problem hiding this comment.
Thanks for catching this. We now use batchScheduler.name to specify the scheduler in the KubeRay Operator, so this label is no longer needed.
As a follow-up, we should also update both the Ray and Volcano docs to reflect the removal of the ray.io/scheduler-name label.
Future-Outlier
approved these changes
Dec 23, 2025
This was referenced Dec 23, 2025
rueian
approved these changes
Dec 24, 2025
github-project-automation
bot
moved this from In Progress
to Done
in @Future-Outlier's kuberay project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously, the
ray.io/scheduler-namelabel was used to determine the scheduler for KubeRay CRDs. However, with the adoption of the new scheduler framework, the scheduler name is now configured via the controller configuration.Since the
ray.io/scheduler-namelabel is no longer in use, I removed it to avoid ambiguity.The Ray documentation will be updated to reflect this change as well.
Related issue number
None
Checks