[kubectl-plugin][Refactor] Standardize namespace resolution to respect kubeconfig context. by kash2104 · Pull Request #4367 · ray-project/kuberay

kash2104 · 2026-01-12T15:03:18Z

Why are these changes needed?

Currently kubectl-plugin failed to respect the kubeconfig context by hardcoding the namespace value to default.

This PR uses Factory's namespace resolution in order to use namespace configured in kubeconfig.

Related issue number

Closes #4318

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

kubectl-plugin/pkg/cmd/create/create_cluster.go

cursor · 2026-01-12T17:18:39Z

kubectl-plugin/pkg/cmd/create/create_cluster.go

+	namespace, _, err := options.cmdFactory.ToRawKubeConfigLoader().Namespace()
+	if err != nil{
+		return "", fmt.Errorf("failed to get current namespace: %w", err)
+	}


Config file namespace ignored due to always-set options.namespace

High Severity

The resolveNamespace() function can no longer use the namespace from a config file. Previously, cmd.Flags().GetString("namespace") returned an empty string when the user didn't pass --namespace, allowing the config file namespace to be used. Now, ToRawKubeConfigLoader().Namespace() always returns a value (at minimum "default"), so options.namespace is never empty. This causes the condition if options.namespace != "" to always be true, making the else if branch that uses rayClusterConfig.Namespace unreachable. Additionally, the error check at line 249 will now incorrectly fail when a config file specifies a namespace different from the kubeconfig default.

Additional Locations (2)

kubectl-plugin/pkg/cmd/create/create_cluster.go#L152-L157

kubectl-plugin/pkg/cmd/create/create_cluster.go#L248-L251

Agree, and I think you should add test to check this

There are some different behavior if the namespace is specified in config file, --file ray-cluster.yaml.

before applying this pr:

after applying this pr:

Future-Outlier

cc @win5923 @lorriexingfang @AndySung320 @400Ping to review

kash2104 · 2026-01-16T01:19:19Z

Currently working on resolving the failing tests.

win5923

CI keeps failing. Could you take a look?
https://github.com/ray-project/kuberay/actions/runs/21089666265/job/60659060831?pr=4367

kash2104 · 2026-01-19T19:14:53Z

I tried but the CI that is failing is TestCompleteFoo from session_test.go where it keeps saying that old-context is not found and hence not taking the namespace and the context from it.

Would appreciate help for debugging and passing this test.

AndySung320 · 2026-01-19T23:54:32Z

Hi @kash2104 ,
in your new test, you're trying to use cmd.Flags().Set() but those flags don't exist anymore since you refactored to use Factory's namespace resolution.
Comparing with the old test (which directly set fakeSessionOptions.namespace), the new approach needs to properly configure ConfigFlags so the Factory can read from it.
You need to:

Set ConfigFlags.Namespace and ConfigFlags.Context directly as pointers (not via cmd.Flags().Set())
Move cmdFactory creation inside the test loop so each test case gets its own configured ConfigFlags
Fix the kubeconfig: your contexts reference non-existent clusters, and "old-context" isn't defined in the contexts map

kubectl-plugin/pkg/cmd/get/get_cluster_test.go

kubectl-plugin/pkg/cmd/create/create_workergroup_test.go

AndySung320

It looks like the Go-build-and-test / Lint (pre-commit) check is still failing.
Could you take a look and fix the lint issues?

kash2104 · 2026-01-25T10:50:46Z

@AndySung320 Have fixed the failing tests.

Future-Outlier

Should we also change completion.go?

kash2104 · 2026-01-27T03:54:50Z

If we change completion.go, then we need to modify it to include variable of cmdUtil.Factory type in order to just get the namespace from the kubeconfig. All the other flags like ray-cluster needs to be set using cobra command only since they are not included in the kubeconfig. So do we want that approach?

Future-Outlier · 2026-01-29T06:03:30Z

If we change completion.go, then we need to modify it to include variable of cmdUtil.Factory type in order to just get the namespace from the kubeconfig. All the other flags like ray-cluster needs to be set using cobra command only since they are not included in the kubeconfig. So do we want that approach?

yes

fscnick · 2026-01-29T15:26:08Z

kubectl-plugin/pkg/cmd/create/create_cluster_test.go

@@ -61,10 +61,11 @@ func TestRayCreateClusterComplete(t *testing.T) {

 	for name, tc := range tests {


Would it be possible to add a test case that respects the namespace in kubeconfig?

fscnick · 2026-01-29T15:35:18Z

kubectl-plugin/pkg/cmd/get/get_cluster_test.go

@@ -70,11 +69,16 @@ func TestRayClusterGetComplete(t *testing.T) {

 	for _, tc := range tests {


cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

kubectl-plugin/pkg/cmd/create/create_cluster_test.go

fscnick · 2026-02-07T11:39:35Z

kubectl-plugin/pkg/cmd/create/create_cluster.go

+	namespace, _, err := options.cmdFactory.ToRawKubeConfigLoader().Namespace()
+	if err != nil{
+		return "", fmt.Errorf("failed to get current namespace: %w", err)
+	}


There are some different behavior if the namespace is specified in config file, --file ray-cluster.yaml.

before applying this pr:

after applying this pr:

fscnick · 2026-02-07T11:54:24Z

kubectl-plugin/pkg/cmd/create/create_workergroup_test.go

+			flags: map[string]string{
+				"namespace": "",
+			},


Why should it add an empty namespace flag? It seems a bit of different from the description above.

cursor bot reviewed Jan 12, 2026

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster.go Show resolved Hide resolved

kubectl-plugin/pkg/cmd/create/create_cluster.go Show resolved Hide resolved

kash2104 force-pushed the issue-4318 branch from f84306c to f238f17 Compare January 12, 2026 17:10

cursor bot reviewed Jan 12, 2026

View reviewed changes

Future-Outlier reviewed Jan 14, 2026

View reviewed changes

kash2104 force-pushed the issue-4318 branch 3 times, most recently from 0d9c447 to f7a7f45 Compare January 16, 2026 18:51

This comment was marked as outdated.

Sign in to view

kash2104 force-pushed the issue-4318 branch 3 times, most recently from ab69d83 to 1d28033 Compare January 17, 2026 06:06

This comment was marked as outdated.

Sign in to view

win5923 reviewed Jan 19, 2026

View reviewed changes

kash2104 force-pushed the issue-4318 branch 2 times, most recently from b8db8cb to e904e1a Compare January 22, 2026 02:04

cursor bot reviewed Jan 22, 2026

View reviewed changes

kubectl-plugin/pkg/cmd/get/get_cluster_test.go Outdated Show resolved Hide resolved

kubectl-plugin/pkg/cmd/create/create_workergroup_test.go Show resolved Hide resolved

kash2104 force-pushed the issue-4318 branch 3 times, most recently from 4b21de4 to b1ff884 Compare January 23, 2026 15:53

AndySung320 reviewed Jan 24, 2026

View reviewed changes

kash2104 force-pushed the issue-4318 branch 3 times, most recently from 16f91e9 to 0d67742 Compare January 25, 2026 10:03

Future-Outlier reviewed Jan 26, 2026

View reviewed changes

Future-Outlier moved this to others in @Future-Outlier's kuberay project Jan 26, 2026

Future-Outlier added this to @Future-Outlier's kuberay project Jan 26, 2026

fscnick reviewed Jan 29, 2026

View reviewed changes

kash2104 force-pushed the issue-4318 branch 2 times, most recently from 9760507 to e4e5aff Compare February 6, 2026 03:23

cursor bot reviewed Feb 6, 2026

View reviewed changes

kubectl-plugin/pkg/cmd/create/create_cluster_test.go Outdated Show resolved Hide resolved

refactor: Standardize namespace resolution for kubectl-plugin.

bb478f4

kash2104 force-pushed the issue-4318 branch from e4e5aff to bb478f4 Compare February 6, 2026 14:22

kash2104 requested review from Future-Outlier and fscnick February 6, 2026 15:33

fscnick reviewed Feb 7, 2026

View reviewed changes

		@@ -61,10 +61,11 @@ func TestRayCreateClusterComplete(t *testing.T) {

		for name, tc := range tests {

		@@ -70,11 +69,16 @@ func TestRayClusterGetComplete(t *testing.T) {

		for _, tc := range tests {

Conversation

kash2104 commented Jan 12, 2026

Why are these changes needed?

Related issue number

Checks

Uh oh!

Uh oh!

Uh oh!

cursor bot Jan 12, 2026

Choose a reason for hiding this comment

Config file namespace ignored due to always-set options.namespace

Uh oh!

400Ping Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fscnick Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

kash2104 commented Jan 16, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

win5923 left a comment

Choose a reason for hiding this comment

Uh oh!

kash2104 commented Jan 19, 2026

Uh oh!

AndySung320 commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

AndySung320 left a comment

Choose a reason for hiding this comment

Uh oh!

kash2104 commented Jan 25, 2026

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

kash2104 commented Jan 27, 2026

Uh oh!

Future-Outlier commented Jan 29, 2026

Uh oh!

fscnick Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

fscnick Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fscnick Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

fscnick Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

400Ping Jan 15, 2026 •

edited

Loading