Skip to content

[historyserver] add prometheus health e2e test for live session #4449

Open
my-vegetable-has-exploded wants to merge 17 commits intoray-project:masterfrom
my-vegetable-has-exploded:prometheus-health-e2e
Open

[historyserver] add prometheus health e2e test for live session #4449
my-vegetable-has-exploded wants to merge 17 commits intoray-project:masterfrom
my-vegetable-has-exploded:prometheus-health-e2e

Conversation

@my-vegetable-has-exploded
Copy link
Contributor

@my-vegetable-has-exploded my-vegetable-has-exploded commented Jan 28, 2026

Why are these changes needed?

This pr follows #4425.

Related issue number

Related #4383

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

fscnick and others added 12 commits January 21, 2026 20:58
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
…y server

Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
…r deletion finished

Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
Copy link
Contributor Author

Success result on ray dashboard.
image
Success result on history server.
image
Failed result on ray dashboard.
image
Failed result on history server.
image

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
Copy link
Contributor Author

my-vegetable-has-exploded commented Jan 29, 2026

This PR implements the endpoint /api/prometheus_health for live session. The overall code is basically the same as #4425. ptal @Future-Outlier

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded my-vegetable-has-exploded marked this pull request as ready for review February 3, 2026 08:14
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@Future-Outlier Future-Outlier self-assigned this Feb 3, 2026
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested this on my laptop, tks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants