[history server][e2e] Add Azure Blob Storage E2E test for History Server#4460
Open
ikchifo wants to merge 10 commits intoray-project:masterfrom
Open
[history server][e2e] Add Azure Blob Storage E2E test for History Server#4460ikchifo wants to merge 10 commits intoray-project:masterfrom
ikchifo wants to merge 10 commits intoray-project:masterfrom
Conversation
ikchifo
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ikchifo
force-pushed
the
feature/azure-historyserver-e2e
branch
from
0b56ac8 to
faf0062
Compare
Refactor ApplyHistoryServer to accept an optional manifest path parameter, eliminating the need for a separate ApplyAzureHistoryServer function. Remove PrepareAzureHistoryServerTestEnv as it was identical to PrepareAzureBlobTestEnv.
ikchifo
force-pushed
the
feature/azure-historyserver-e2e
branch
from
faf0062 to
058506b
Compare
Contributor
Author
|
Bumping this @Future-Outlier. PTAL when you get the chance. |
Member
will do this recently, tks! |
Member
|
Hi, @ikchifo the CI fails, do you mind take a look? |
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
Hi, @ikchifo
I just helped you solve the merge conflict, do you mind help me add the dead cluster's e2e test? since this is the most important part of the history server.
4 tasks
Add e2e tests for Azure Blob Storage that verify history server functionality after cluster deletion: - testAzureDeadClusters: verifies all endpoints work for dead clusters - testAzureLogFileEndpointLiveCluster: verifies log file access for live - testAzureLogFileEndpointDeadCluster: verifies log file access for dead Extract shared test helpers to avoid duplication between S3 and Azure: - VerifyLogFileEndpointReturnsContent - VerifyLogFileEndpointRejectsPathTraversal - DeleteRayClusterAndWait
Contributor
Author
|
@Future-Outlier Added! Also, to avoid code duplication between S3 and Azure tests, I extracted shared verification helpers into
|
…luster-id The Azure dead cluster tests were failing because the collector uploaded logs to a path based on the hardcoded 'default' namespace, but the history server searched for clusters in the test namespace. Add --ray-cluster-id injection to ApplyAzureRayClusterWithCollector, matching the behavior of the S3 test helper, so logs are uploaded to the correct namespace-prefixed path.
Update Azure collector tests to use namespace.Name instead of hardcoded RayClusterID constant, matching the S3 collector test pattern. This ensures the expected blob path matches the actual upload path when --ray-cluster-id is injected dynamically.
ikchifo
force-pushed
the
feature/azure-historyserver-e2e
branch
from
647bf88 to
b7df758
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds Azure Blob Storage support for the History Server E2E tests. It is a follow-up to #4413 which added Azure Blob Storage support for the Collector component.
With the Collector now supporting Azure Blob Storage, users need:
Changes:
historyserver/config/historyserver-azureblob.yaml- History Server deployment configured for Azure Blob Storage (Azurite)historyserver/test/e2e/historyserver_azureblob_test.go- E2E test for live clusters using AzureRelated issue number
Closes #4459
Checks