[History Server Tests] end-to-end Tests for Dead Cluster Endpoints#4470
Open
sb-hakunamatata wants to merge 5 commits intoray-project:masterfrom
Open
[History Server Tests] end-to-end Tests for Dead Cluster Endpoints#4470sb-hakunamatata wants to merge 5 commits intoray-project:masterfrom
sb-hakunamatata wants to merge 5 commits intoray-project:masterfrom
Conversation
Author
|
@Future-Outlier please review. |
4 tasks
Future-Outlier
requested changes
Feb 5, 2026
Member
There was a problem hiding this comment.
Hi, thanks for the PR.
- can you do something like this PR? #4461
- don't add a new file, instead, add endpoints to historyserver/test/e2e/historyserver_test.go
- the goal of your PR is to add
taskendpoint, so plz don't include actor - please change the title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes RayJob submission failures in History Server E2E tests and adds coverage for History Server behavior when the Ray cluster is deleted (dead cluster scenario).
What changed
Added a new dead-cluster E2E test suite under
tests/e2eto verify History Server endpoints return HTTP 200 and valid JSON after the live Ray cluster is deleted:/api/v0/tasks/api/v0/tasks?filter_keys=job_id.../api/v0/tasks/summarize/logical/actors/logical/actors/{actor_id}/nodes?view=summaryUpdated the test helper
ApplyRayJobAndWaitForCompletionto assign a unique RayJob name on every submission by appending a UUID.Why
The same RayJob manifest is submitted multiple times within a single E2E test.
Reusing the same RayJob name caused submission failures due to Kubernetes resource name collisions.
Making the RayJob name unique ensures:
Testing
Rollback plan
Related issue number
Fixes #4378
Checks