add skeleton code for cache pod manager#4474
Open
lw309637554 wants to merge 6 commits intoray-project:masterfrom
Open
add skeleton code for cache pod manager#4474lw309637554 wants to merge 6 commits intoray-project:masterfrom
lw309637554 wants to merge 6 commits intoray-project:masterfrom
Conversation
Signed-off-by: Rueian <rueiancsie@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Execute the command | ||
| if err := cmd.Execute(); err != nil { | ||
| klog.Fatalf("Command execution failed: %v", err) | ||
| } |
There was a problem hiding this comment.
Command-line flags never parsed or connected to Cobra
High Severity
The flags (kubeconfig, node-name, os, arch) are defined using the standard flag package in init(), but the main() function uses Cobra for command execution without integrating these flags. Since neither flag.Parse() is called nor cmd.Flags().AddGoFlagSet(flag.CommandLine) is used to connect the standard library flags to Cobra, all command-line arguments will be ignored. The variables will always have their default values regardless of user input.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks