[Feature][history server] Add Google Cloud Storage (GCS) support to history server#4478
[Feature][history server] Add Google Cloud Storage (GCS) support to history server#4478chiayi wants to merge 4 commits intoray-project:masterfrom
Conversation
5c8c161 to
83a0115
Compare
|
I was able to utilize the github.com/fsouza/fake-gcs-server/fakestorage library in the test suite but it also looks like there is also an emulator that we could use in our CI. I think that can be the next step. |
|
To manually test, I upload My GKE cluster was previously created so I updated it to use workload identity using Followed this guide to setup workload identity and connect Kubernetes SA with Google SA. Deploy RayCluster with this collector: And historyserver: Viewing GCS should then start populating and every current endpoint should work as expected. |
83a0115 to
37ff80e
Compare
192ba5f to
06b8db3
Compare
020734c to
b50592e
Compare
b50592e to
e70ec5c
Compare
e70ec5c to
a268548
Compare
|
|
||
| // Check if bucket exists | ||
| _, err = storageClient.Bucket(c.Bucket).Attrs(ctx) | ||
| if err == gstorage.ErrBucketNotExist { |
There was a problem hiding this comment.
Equality check instead of errors.Is for sentinel error
Medium Severity
The check err == gstorage.ErrBucketNotExist uses direct equality instead of errors.Is(). If the error is wrapped, this comparison will fail, causing the code to fall through to the generic error branch instead of attempting bucket creation. The same file correctly uses errors.Is(err, gstorage.ErrObjectNotExist) on line 48, making this inconsistent.



Why are these changes needed?
Provide Google Cloud Storage support for the history server
Related issue number
Part of #4453
Checks