Skip to content

[RayService][e2e] fix flaky test in getting HTTPRoute#4701

Merged
rueian merged 1 commit intoray-project:masterfrom
fscnick:fix-flaky-test-in-incr-upgrade-e2e
Apr 13, 2026
Merged

[RayService][e2e] fix flaky test in getting HTTPRoute#4701
rueian merged 1 commit intoray-project:masterfrom
fscnick:fix-flaky-test-in-incr-upgrade-e2e

Conversation

@fscnick
Copy link
Copy Markdown
Collaborator

@fscnick fscnick commented Apr 13, 2026

Why are these changes needed?

There is a flaky test in incremental upgrade e2e test. The pr turns the verification of the readiness of HTTPRoute to Eventually to wait for the status. It might not that easy to reproduce the original test failure, I ran 3x times of test to encounter an test failure.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: fscnick <fscnick.dev@gmail.com>
@fscnick
Copy link
Copy Markdown
Collaborator Author

fscnick commented Apr 13, 2026

Thanks @JiangJiaWei1103 for help.

There is the log after running 100 time without the test failure on the same test in the flaky test. By the way, there are some additional logs in Eventually for observation and it has been remove in this PR.
additional log

The log and the result in short.
test-e2e-incremental-upgrade.100.log
log verify

Copy link
Copy Markdown
Contributor

@JiangJiaWei1103 JiangJiaWei1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

I also found it hard to reproduce locally. The following shows the test result after this fix (100 success in a row):

Screenshot 2026-04-13 at 12 12 23 PM

@fscnick fscnick marked this pull request as ready for review April 13, 2026 04:33
Copy link
Copy Markdown
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, cc @andrewsykim @rueian to merge

@rueian rueian merged commit 4491833 into ray-project:master Apr 13, 2026
31 checks passed
@github-project-automation github-project-automation bot moved this from can be merged to Done in @Future-Outlier's kuberay project Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants