[RayService][e2e] fix flaky test in getting HTTPRoute#4701
Merged
rueian merged 1 commit intoray-project:masterfrom Apr 13, 2026
Merged
[RayService][e2e] fix flaky test in getting HTTPRoute#4701rueian merged 1 commit intoray-project:masterfrom
rueian merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Collaborator
Author
|
Thanks @JiangJiaWei1103 for help. There is the log after running 100 time without the test failure on the same test in the flaky test. By the way, there are some additional logs in The log and the result in short. |
JiangJiaWei1103
approved these changes
Apr 13, 2026
win5923
approved these changes
Apr 13, 2026
Future-Outlier
approved these changes
Apr 13, 2026
Member
Future-Outlier
left a comment
There was a problem hiding this comment.
looks correct, cc @andrewsykim @rueian to merge
rueian
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why are these changes needed?
There is a flaky test in incremental upgrade e2e test. The pr turns the verification of the readiness of HTTPRoute to Eventually to wait for the status. It might not that easy to reproduce the original test failure, I ran 3x times of test to encounter an test failure.
Related issue number
Checks